It'd be nice if I could tell `mach rusttests` which packages I wanted to test with `-p`
Categories
(Firefox Build System :: General, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: chutten, Unassigned)
References
Details
I don't necessarily want to run all of the tests every time, so maybe we could pass cargo tests' filtering arguments through mach rusttests?
Also, I hear that cargo test has some other neat features we might eventually want to take advantage of, so it could be nice to pass more or less all of mach rusttests' command arguments to cargo test.
(( though I really have no idea if that's feasible or desirable in mach ))
|
||
Comment 1•5 years ago
|
||
I agree, that would be nice. I'm not sure that it's feasible given how rusttests is implemented (it doesn't directly invoke cargo test, but it performs a build with make that ends up eventually indirectly invoking cargo test).
It's conceivable we could use environment variables (for example) to do something like this but I'm not sure it's high-priority, so I'm inclined to close as WONTFIX. Even if we did do that I'm also concerned about how cargo's caching would be affected and how we could ensure that mach rusttests never reports false positives.
(Implementation note: it's worth considering how the outcome of bug 1609800 could affect this, as it might make it more practical to directly run cargo test from within mach rusttests.)
|
Reporter | |
Comment 2•5 years ago
|
||
Totally fair. I'll "See Also" from here as a little string in case bug 1609800 goes well and this could be taken as a follow-up.
|
||
Comment 3•5 years ago
|
||
Just adding up on what Chris said here: it would be really neat to have test filtering capabilities, as I'm now having the same need of running a subset of the Rust tests.
Allowing test debugging... that would be even better :-P
Description
•