1627317 - If stories are disabled, collections can still show up

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Comment 1

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Users that have pocket disabled may still see collections, which would be not awesome UX.

Comment 2

[Scott [:thecount] Downe]

To test:

1. Set browser.newtabpage.activity-stream.discoverystream.spocs-endpoint to "https://spocs.getpocket.com/spocs?country=US&region=CA&site=1116390"
2. Ensure you can see spocs and collections.
3. Go to about:preferences#home and turn "rescommended by pocket" off
4. Go to a new tab.

Expected, should not see any stories or collections.

Comment 3

[Scott [:thecount] Downe]

Attachment: Bug 1627317 - Ensure collections are also disabled, if newtab stories are disabled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b670d9077d4b
Ensure collections are also disabled, if newtab stories are disabled. r=gvn

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b670d9077d4b

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (77.0a1 Build ID - 20200408033650) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.3. Now, the “Collections” section is no longer displayed if the “Recommended by pocket” option is unchecked from the “about:preferences#home” page.

Comment 7

[Scott [:thecount] Downe]

Comment on attachment 9138121 [details]
Bug 1627317 - Ensure collections are also disabled, if newtab stories are disabled.

Beta/Release Uplift Approval Request

• User impact if declined: Significant user experience impact if we turn on Pocket collections.

Pocket collections is a new list of pocket stories that are connected somehow.

If we turn these on right now and the user has stories disabled, they still see collections, which is not great to see something the user opted out of.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: To test:

1. Set browser.newtabpage.activity-stream.discoverystream.spocs-endpoint to "https://spocs.getpocket.com/spocs?country=US&region=CA&site=1116390"
2. Ensure you can see spocs and collections.
3. Go to about:preferences#home and turn "rescommended by pocket" off
4. Go to a new tab.

Expected, should not see any stories or collections.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Its tested, verified, and a 2 line change.
• String changes made/needed: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9138121 [details]
Bug 1627317 - Ensure collections are also disabled, if newtab stories are disabled.

Approved for 76.0b3.

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ba3b9444b9d1

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (76.0b4 Build ID - 20200412214314) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.3. Now, the “Collections” section is no longer displayed if the “Recommended by pocket” option is unchecked from the “about:preferences#home” page.