1627366 - Automatically reveal password when user taps into password field in edit mode

Status: RESOLVED WONTFIX

(Firefox :: about:logins, enhancement, P3)

Description

[Amy Lee [:amylee] UX]

Steps to reproduce:

1. Go to about:logins -> Edit
2. Type in credentials to open edit mode
3. Tap in password field

Expected:
Password is revealed and "reveal" icon changes to "hide"

Actual:
Password is still hidden and user must tap on "reveal" icon to show password

Comment 1

[Matthew N. [:MattN]]

To Do:

• Hide the eye icon when in edit mode (.reveal-password-checkbox). That probably means adding it to here with an appropriate selector. Leave the existing behaviour in creation mode.
• Add a "focus" and "blur" event listener on the password field to set this._revealCheckbox.checked and call this._updatePasswordRevealState(); when appropriate. (see the related code for the eye icon).
• Fix any failing tests from ./mach test browser/components/aboutlogins (you can add --headless) so you can do other things while tests are running.
• Add a test task similar to https://searchfox.org/mozilla-central/rev/9120151ddb35f2d4c37bfe613a54a4f10a9a3dc5/browser/components/aboutlogins/tests/chrome/test_login_item.html#249-278 for the new functionality.

Comment 2

[aarushivij]

Hello,
Can I take up this issue?
Thanks :)

Comment 3

[aarushivij]

Attachment: editIssue.png

Hey, I was trying to reproduce the issue, but couldn't find where this issue exists.
I opened edit mode for a saved login, but it worked as expected.
Thanks for the help :)
Aarushi

Comment 4

[Matthew N. [:MattN]]

Your screenshot is showing the problem except you are in create mode, not edit mode.

When you have focused the password field, like in your screenshot, the text should be revealed, not dots, when in edit mode. Therefore the eye icon should also be hidden since it's not necessary.

Comment 5

[aarushivij]

Okay, Shall start working on it.
Thanks :)

Comment 6

[Adam Morris]

If aarushivij isn't working on this/isn't assigned, could I please be assigned this bug?

Comment 7

[aarushivij]

Hello, @adam you can work on this :)
I got another bug to work upon, so you can try this one :)
All the best

Comment 8

[Adam Morris]

I'm working on this now.
@MattN, should dots be displayed when the textbox isn't focused?

Comment 9

[Matthew N. [:MattN]]

(In reply to Adam Morris from comment #8)

I'm working on this now.
@MattN, should dots be displayed when the textbox isn't focused?

Yes

Comment 10

[Matthew N. [:MattN]]

Hello Adam, how is the patch coming along?

Comment 11

[Matthew N. [:MattN]]

Hey Adam, since we haven't heard from you for a while I'm going to unassign this for now.

Comment 12

[Tim Giles [:tgiles]]

Attachment: Bug 1627366 - Automatically reveal password when user taps into password field in edit mode. r=bdanforth

Comment 13

[Tim Giles [:tgiles]]

Attachment: Bug 1627366 - add focus and blur handlers for password in edit mode. r=bdanforth

Depends on D84436

Comment 14

[katieC]

UX Recommendation: This is the intended behaviour, and is not a bug.
When the user enters EDIT mode, we do not want to presume their intention, ex: they may be editing their username. The password manager protects (masks) their password everywhere until the user intentionally unmasks (by tapping the eye icon - as is the pattern elsewhere in the product). UI elements should not disappear - but should remain consistent in placement and behaviour.

Comment 15

[Matthew N. [:MattN]]

(In reply to katieC from comment #14)

When the user enters EDIT mode, we do not want to presume their intention, ex: they may be editing their username.

I don't think that was what this bug was about… it was about what happens when you then click into the password field. There isn't much useful you can do in the password without revealing the password: you can't copy. All you can do is blindly delete pieces of the masked password which doesn't seem that useful.

The password manager protects (masks) their password everywhere until the user intentionally unmasks (by tapping the eye icon - as is the pattern elsewhere in the product).

That's not the case for password generation btw.

UI elements should not disappear - but should remain consistent in placement and behaviour.

Did you test the current behaviour? That's not the case right now. The copy button isn't shown in edit mode and the layout of the position of the fields is different in edit mode.

Comment 16

[katieC]

After a conversation with Matt, eng and ux agree that the current ux, the show/hide icon are the control for the masking/unmasking the password.