Closed Bug 1627367 Opened 4 years ago Closed 4 years ago

Remove content process crash annotation blacklist

Categories

(Toolkit :: Crash Reporting, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(1 file)

Crash annotations from content process crashes are taken from the child process, except when they're not set in which case they're taken from the parent process annotations. This is done transparently now but before bug 1547698 we wrote the .extra file in three distinct passes, each of which appended annotations to it. Since the main process appended its annotations after the content process some could overwrite the content ones as the earlier ones would be ignored when the file was parsed. To solve this problem we introduced a blacklist of annotations from the main process which should not be written out for content process crash reports.

Since bug 1547698 all annotations for a content process crash are taken from the content process with only the empty ones being filled up from the parent process. As such the blacklist is now useless.

Assignee: nobody → gsvelto
Status: NEW → ASSIGNED

This needs rebasing after bug 1614933. Fortunately the rebased patch should be even simpler than the original.

Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87a620cb7c5a
Remove the content process crash annotation blacklist r=KrisWright
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: