162750 - History sidebar does not show dates

Status: RESOLVED FIXED

(Camino Graveyard :: History, defect)

Description

[Prachi Gauriar]

In the first level of the History sidebar's NSOutlineView, the dates don't show
up. Instead, you only see 0 (Today), 1 (Yesterday), 2 (Two days ago), etc... 

Instead, it should say:

Today
Yesterday
<Weekday, Date>

Comment 1

[Prachi Gauriar]

Attachment: Patch to CHHistoryDataSource.mm

Basically, when setting the title of an item in the NSOutlineView, check to see
if the item is at level 0. If so, find out how many days ago it was (by getting
the intValue of the string), and create the proper title based on that.

This should be localization friendly.

Comment 2

[Benoit]

Another possibility is to just add the history.properties file to embed.jar by
adding the following line into embed-jar.mn:

"locale/XXXX/communicator/history/history.properties, 
XXXX/locale/XXXX/communicator/history/history.properties"

I've no idea which way is better!

See bug_154297 for more details.

Comment 3

[Greg K.]

History sidebar? In what build is there a history sidebar? I don't see one in
2002081505.

Comment 4

[Simon Fraser [no longer active]]

You have to set the pref: 
user_pref("chimera.show_history", true);

Comment 5

[Prachi Gauriar]

Simon, have you had a chance to look at this yet? No biggy if you haven't had a
chance yet (since the history sidebar isn't even enabled by default).

Comment 6

[Mike Pinkerton (not reading bugmail)]

heh, i came up with the embed-jar.mn fix on my own. fixed, but we'll need a
different fix for the trunk since we can't just go editing that file willy-nilly.

Comment 7

[sairuh (rarely reading bugmail)]

yay!

vrfy'd fixed on 10.2.2, with 2002.11.12.04.

Comment 8

[Prachi Gauriar]

Reopening. This issue has reappeared in Camino build 2003030808 upon merging
with the trunk (as comment #6 predicted). 

Comment 9

[Simon Fraser [no longer active]]

*** Bug 196552 has been marked as a duplicate of this bug. ***

Comment 10

[Simon Fraser [no longer active]]

*** Bug 197413 has been marked as a duplicate of this bug. ***

Comment 11

[Lorin Rivers]

I searched for this, I SWEAR! Sorry about the duplicate bidness...

Comment 12

[Mike Pinkerton (not reading bugmail)]

fixed last night

Comment 13

[Hiro]

This bug is reappearing again.
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.6a) Gecko/20031023
Camino/0.7+