[wpt-sync] Sync PR 22705 - Fix ordering issue within NGBlockLayoutAlgorithm::ComputeMinMaxSizes
Categories
(Core :: Layout, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 22705 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/22705
Details from upstream follow.
Ian Kilpatrick <ikilpatrick@chromium.org> wrote:
Fix ordering issue within NGBlockLayoutAlgorithm::ComputeMinMaxSizes
The DCHECK in the bug was caused by an order-of-operations issue.
Within the following calculation:
max_inline_contribution =
child_sizes.max_size + line_left_inset + line_right_inset;If:
child_sizes.max_size == LayoutUnit::Max()
line_left_inset == LayoutUnit(1)
line_right_inset == LayoutUnit(-1)max_inline_contribution would be LayoutUnit::Max() - LayoutUnit(1);
This resulted in max_size \< min_size.
Bug: 1004060
Change-Id: I3e439500f07a2cd1cf0cbe5528ece16090c9fa70Reviewed-on: https://chromium-review.googlesource.com/2136885
WPT-Export-Revision: 7726b85800e436a4db2e5c567c478dba0587482a
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4268473eb9614488105c4a116f7f5abcc25bf4b8
Assignee | ||
Comment 2•4 years ago
|
||
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/27460fa1b217 [wpt PR 22705] - Fix ordering issue within NGBlockLayoutAlgorithm::ComputeMinMaxSizes, a=testonly
Comment 4•4 years ago
|
||
bugherder |
Description
•