1627684 - Private window clear popup cookie

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect, P2)

Description

[Lucas]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36

Steps to reproduce:

1 - Open a website (that use cookies) in private window;
2 - Access a popup window of this web site;
3 - Close website, verifying the cookies in popup were cleaned;

Actual results:

Only in private window, firefox lost cookies of popup when close parent window.

Expected results:

Cookies in the popup shouldn't be cleared.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Johann Hofmann [:johannh]]

If I understand you correctly, you open a new pop up window from a private window and expect that popup window to retain its cookies when the private window is closed? I don’t really see how that would work given the privacy guarantees of private windows and how trivial it is for websites to open new popups...

Comment 3

[Lucas]

The point is, only in Firefox that's happened. Don't make sense clear the popup's cookie when close the parent window. Any website use cookie feature, so that's are important.

Comment 4

[Johann Hofmann [:johannh]]

Ah yes, sorry, I misunderstood you initially. You're right that something weird is going on here. The private popup window should keep that session alive, but it doesn't for some reason.

It may be because they're sharing the same process, i.e. here: https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/dom/ipc/ContentParent.cpp#4134 the list might get confused by that. But that's honestly just a guess.

Someone will have to take a deeper look.

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1627684 - Propagate the affect-private-session-lifetime flag for window.open(), r?smaug

Comment 6

[Andrea Marchesini [:baku]]

Attachment: Bug 1627684 - Propagate the affect-private-session-lifetime flag for window.open() - tests, r?johannh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dafb91295af
Propagate the affect-private-session-lifetime flag for window.open(), r=smaug
https://hg.mozilla.org/integration/autoland/rev/26751e4113d8
Propagate the affect-private-session-lifetime flag for window.open() - tests, r=johannh

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_privatebrowsing_cleanup.js

backout: https://hg.mozilla.org/integration/autoland/rev/deec9b9e31b1b9b49f733c112193acf1398002f4

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=15f28d419ea6ee19c8e3a8f6f2cd7017ef42c4c5&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-fis-e10s-3%2Cm-fis%28bc3%29&selectedJob=298982399

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298982399&repo=autoland&lineNumber=5239

[task 2020-04-23T08:30:04.840Z] 08:30:04 INFO - GECKO(3701) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpLQZHVw.mozrunner/runtests_leaks_tab_pid4373.log
[task 2020-04-23T08:30:04.840Z] 08:30:04 INFO - GECKO(3701) | [4373, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 221
[task 2020-04-23T08:30:04.861Z] 08:30:04 INFO - TEST-INFO | started process screentopng
[task 2020-04-23T08:30:05.345Z] 08:30:05 INFO - TEST-INFO | screentopng: exit 0
[task 2020-04-23T08:30:05.345Z] 08:30:05 INFO - Buffered messages logged at 08:30:03
[task 2020-04-23T08:30:05.345Z] 08:30:05 INFO - Entering test bound
[task 2020-04-23T08:30:05.345Z] 08:30:05 INFO - Buffered messages finished
[task 2020-04-23T08:30:05.345Z] 08:30:05 INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_cleanup.js | Notification received! -

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb134173a2af
Propagate the affect-private-session-lifetime flag for window.open(), r=smaug
https://hg.mozilla.org/integration/autoland/rev/1e2d1be21c49
Propagate the affect-private-session-lifetime flag for window.open() - tests, r=johannh

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/cb134173a2af
https://hg.mozilla.org/mozilla-central/rev/1e2d1be21c49