1627767 - moz-phab submit submitting patches without dates

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P1)

Description

[:Gijs (he/him)]

I just submitted https://phabricator.services.mozilla.com/D69849 . It has no date information ( https://phabricator.services.mozilla.com/D69849?vs=on&id=255994#toc ).

Output on my side:

$ moz-phab submit . -y
Submitting 1 commit for review:
(New) 587887:c66fb4042a88 Bug 1618375 - handle empty blocklist.xml file in case of crashes, r?florian
Warning: found 11762 untracked files (will not be submitted):

Creating new revision:
587887:c66fb4042a88 Bug 1618375 - handle empty blocklist.xml file in case of crashes, r?florian
warning: no files linted
✖ 0 problems (0 errors, 0 warnings)
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
(activating bookmark moz-phab_c66fb4042a88)

Completed
(D69849) 587888:d5ab33db8fb0 Bug 1618375 - handle empty blocklist.xml file in case of crashes, r?florian
-> https://phabricator.services.mozilla.com/D69849
$ hg parent
changeset:   587888:d5ab33db8fb0
tag:         tip
parent:      587531:b219cfa26dc2
user:        Gijs Kruitbosch <[e-mail]>
date:        Mon Apr 06 18:43:26 2020 +0100
summary:     Bug 1618375 - handle empty blocklist.xml file in case of crashes, r?florian

This is bad because it leads to commits landing without date info, which in turn leads to brokenness elsewhere (cf. bug 1627229).

Comment 1

[:Gijs (he/him)]

From matrix:

@kwan > gijs: no date doesn't seem to be exclusive to the hg code of moz-phab, seems like it applies to the git one as well: https://phabricator.services.mozilla.com/D69830?id=255883

Comment 2

[Ian Moody [:Kwan] (UTC+1)]

I think using moz-phab submit --arc would be a temporary workaround for users.

Comment 3

[Piotr Zalewa [:zalun]]

Attachment: Bug 1627767 - Submit commit date info. r=glob