Remove getCssProperties(toobox) helper
Categories
(DevTools :: General, task, P3)
Tracking
(firefox77 fixed)
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
Details
Attachments
(1 file)
The getCssProperties() helper in devtools/client/fronts/css-properties.js doesn't seem to be used anywhere aside from three tests, one of which tests the method itself:
- devtools/client/inspector/shared/test/browser_styleinspector_output-parser.js
- devtools/client/shared/test/browser_outputparser.js
- devtools/server/tests/chrome/test_css-properties.html
getCssProperties() seems to be leveraging a cached CssProperties object, keyed by DevtToolsClient instance. But there aren't any consumers for this.
The CssProperties object is a reconcilliation between a client CSS database with one received from the CssProperties front which attempts to return an accurate list of CSS properties and capabilities supported by the server.
But in two of the tests, the actual usage of getCssProperties() is against a mock object, circumventing a trip to the server. For this use case, the getClientCssProperties() method seems more appropriate.
Given the lack of meaningful usage, the getCssProperties() helper should be removed.
|
||
Comment 1•4 years ago
|
||
As mentioned on slack:
- this was introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=1268082
- call sites were intentionally removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1494162
- exact changeset: https://hg.mozilla.org/mozilla-central/rev/2c68f94353082ab810ab4bb81f2d88273229fba2
IMO it's fine to remove this, the front has not been used for 18 months, it seems like a leftover from the previous cleanup.
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1aa79304d2f4 Remove unused getCssProperties() helper r=gl
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•