Closed Bug 1627873 Opened 4 years ago Closed 4 years ago

Stalls during a mach command may not show the last bits of output before stall

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

When the build is stalled for some random reason, and mach executed a python subcommand (this may or may not be limited to python 3, I'm not sure, and it doesn't really matter since it's a problem on python 3, which matters most), the subcommand may not have actually sent its last bits of output before the stall because its output is a pipe and in that case python uses buffered outputs.

Now, when your build is completely stalled and you ctrl+C, you end up without these bits of output, and in some cases, those bits of output can contain actual information, like... tracebacks.

A real life example of this is bug 1624670 when running mach build or mach configure with the patches from bug 1627163 applied, and configure stalls without printing out the ValueError message at all.

When the build is stalled for some random reason, and mach executed a
python subcommand (this may or may not be limited to python 3, I'm not
sure, and it doesn't really matter since it's a problem on python 3,
which matters most), the subcommand may not have actually sent its last
bits of output before the stall because its output is a pipe and in that
case python uses buffered outputs.

Now, when your build is completely stalled and you ctrl+C, you end up
without these bits of output, and in some cases, those bits of output
can contain actual information, like... tracebacks.

A real life example of this is bug 1624670 when running mach build or
mach configure with the patches from bug 1627163 applied, and configure
stalls without printing out the ValueError message at all.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/6663d3dc883b
Always unbuffer python output when invoking python commands from mach. r=firefox-build-system-reviewers,rstewart
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Regressions: 1628838
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: