Closed Bug 1627983 Opened 5 years ago Closed 5 years ago

Remove hack in reset Firefox dialog that worked around bug 1620575

Categories

(Firefox :: Migration, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 77
Tracking Status
firefox77 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(3 files)

This code should be obsolete now that bug 1620575 fixed the issue inside layout.

I tested this locally and believe this doesn't regress, but Itiel/Alice, if you could confirm this try build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fcd11d1ede23018db1f7610c4edae1df1f9c50e

doesn't regress bug 1600919 in your usual setups, that'd be great. Thank you!

Flags: needinfo?(itiel_yn8)
Flags: needinfo?(alice0775)
Priority: -- → P3
Attached image screenshot

(In reply to :Gijs (he/him) from comment #2)

I tested this locally and believe this doesn't regress, but Itiel/Alice, if you could confirm this try build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fcd11d1ede23018db1f7610c4edae1df1f9c50e

doesn't regress bug 1600919 in your usual setups, that'd be great. Thank you!

On Windows10 Japanese, text-zoom 150% Ease of Access Settings.
The problem back with the try build.

Flags: needinfo?(alice0775)
Flags: needinfo?(itiel_yn8)

I'm very sorry, I forgot to check what I used as the base for the trypush, so I pushed to try from a base of central without the fix from bug 1620575. :-(

Can you try this trypush instead:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4bbbc150551e519f8d68c3dbe050fe240164b60

Flags: needinfo?(itiel_yn8)
Flags: needinfo?(alice0775)

(In reply to :Gijs (he/him) from comment #4)

I'm very sorry, I forgot to check what I used as the base for the trypush, so I pushed to try from a base of central without the fix from bug 1620575. :-(

Can you try this trypush instead:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4bbbc150551e519f8d68c3dbe050fe240164b60

The try build seems to OK.

Flags: needinfo?(alice0775)
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/fecc21d0fe88 remove frontend hack now that layout correctly handles rounding of content sizes, r=MattN

Thanks, Alice!

Flags: needinfo?(itiel_yn8)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: