1627996 - bouncer nazgul aliases job fails for missing nazgul server scope in sanity checking

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Bouncer, defect)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

We recently landed the patches from bug 1609174 to enable bouncer nazgul jobs, cloning the existing behaviors for bouncers. Looking at the Firefox releases, turns out those were failing today.

2020-04-07 11:59:52,240 - bouncerscript.script - INFO - Sanity check to ensure aliases have been successfully updated...
Traceback (most recent call last):
  File "/app/bin/bouncerscript", line 10, in <module>
    sys.exit(main())
  File "/app/lib/python3.8/site-packages/bouncerscript/script.py", line 175, in main
    client.sync_main(async_main, config_path=config_path, default_config=default_config, should_validate_task=False)
  File "/app/lib/python3.8/site-packages/scriptworker/client.py", line 165, in sync_main
    loop.run_until_complete(_handle_asyncio_loop(async_main, context))
  File "/usr/local/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/app/lib/python3.8/site-packages/scriptworker/client.py", line 204, in _handle_asyncio_loop
    await async_main(context)
  File "/app/lib/python3.8/site-packages/bouncerscript/script.py", line 160, in async_main
    await action_map[context.action](context)
  File "/app/lib/python3.8/site-packages/bouncerscript/script.py", line 87, in bouncer_aliases
    await check_aliases_match(context)
  File "/app/lib/python3.8/site-packages/bouncerscript/task.py", line 193, in check_aliases_match
    url_template = GO_BOUNCER_URL_TMPL[context.server]
KeyError: 'project:releng:bouncer:server:production-nazgul'

Full log here.

The fix should be simple, we should enrich bouncerscript here to encompass the new scope-server.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: [bouncerscript] Bug 1627996 - fix bouncer nazgul jobs

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

The PR has landed and got deployed to production. I'll check on tomorrow's betas to make sure they are green.

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #2)

The PR has landed and got deployed to production. I'll check on tomorrow's betas to make sure they are green.

Green bouncer-aliases for nazgul in latest beta - https://firefox-ci-tc.services.mozilla.com/tasks/P9CpIP5QQGaqJHK_gSEB-A