Closed Bug 1628079 Opened 1 year ago Closed 1 year ago

Use URIFixup to determine if we should show search suggestions

Categories

(Firefox :: Address Bar, task, P2)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: harry, Assigned: harry)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1628079 - Use URIFixup to determine if we should show search suggestions. r?mak!
47 bytes, text/x-phabricator-request
Details | Review

Originally suggested by Marco here.

This is to replace this safety check in UnifiedComplete that is being removed in bug 1623637.

Blocks: qb-results-papercuts
Type: enhancement → task
Priority: -- → P2
Blocks: 1623848
No longer blocks: qb-results-papercuts
Points: --- → 3
Blocks: 1551049
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
No longer blocks: 1551049
Depends on: 1551049

Currently we run a looksLikeUrl check on each token of the typed query. If any look like a URL, we don't show results. We spoke with Product, and we're instead going to show suggestions in all cases except when URIFixup identifies the full query as a URI. This should offer suggestions for all the examples in bug 1551049 comment 0.

We are also going to run an experiment (bug 1643386) to see if users find suggestions based on short queries useful, to potentially not fetch suggestions for those queries to improve user privacy.

Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/378fffbba8cf
Use URIFixup to determine if we should show search suggestions. r=mak

https://hg.mozilla.org/mozilla-central/rev/378fffbba8cf

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
Regressions: 1647881
You need to log in before you can comment on or make changes to this bug.