1628326 - Crash in [@ mozilla::FlacTrackDemuxer::FastSeek]

Status: RESOLVED DUPLICATE of bug 1850453

(Core :: Audio/Video: Playback, defect, P3)

Description

[rctgamer3]

This bug is for crash report bp-ff1689c2-b4cc-4afc-b055-422c20200408.

Top 10 frames of crashing thread:

0 xul.dll mozilla::FlacTrackDemuxer::FastSeek dom/media/flac/FlacDemuxer.cpp
1 xul.dll mozilla::FlacTrackDemuxer::Seek dom/media/flac/FlacDemuxer.cpp:688
2 xul.dll mozilla::detail::ProxyFunctionRunnable<`lambda at /builds/worker/checkouts/gecko/dom/media/MediaFormatReader.cpp:580:16', mozilla::MozPromise<mozilla::media::TimeUnit, mozilla::MediaResult, 1> >::Run xpcom/threads/MozPromise.h:1460
3 xul.dll mozilla::TaskQueue::Runner::Run xpcom/threads/TaskQueue.cpp:207
4 xul.dll nsThreadPool::Run xpcom/threads/nsThreadPool.cpp:299
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1220
6 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:481
7 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:332
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308
9 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290

Comment 1

[rctgamer3]

This is reproducible every time on some specific FLAC files.

Comment 2

[C.M.Chang[:chunmin]]

(In reply to rctgamer3 from comment #1)

This is reproducible every time on some specific FLAC files.

rctgamer3, could you put the links for these FLAC files here so we can check?

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

Add a macOS-specific signature for this crash. The crash reports include this URL: https://nookipedia.com/wiki/Comrade_K.K.

I managed to repro with the following STR:

1. Browser to https://nookipedia.com/wiki/Comrade_K.K. using nightly
2. Click the play button on the Live Performance audio sample visible on the right
3. Start seeking around the track by dragging the track position handle around, the crash happens within a couple of seconds

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

I could repro on Linux too so this affects all platforms.

Comment 5

[rctgamer3]

Here's a direct to one of the affected flacs. No page required, just seek around in the file.
https://nookipedia.com/w/images/8/8a/NH_BGM_Audio_053_Kekesong_Hifi.flac

Comment 6

[Wim Brand]

I think I have this issue too. I'm using Firefox 75.0 on Manjaro Linux.

When playing this FLAC file ( https://pixeldrain.com/u/46tg85mZ ) it crashes at exactly 1:07 every time. The song is royalty free, so you don't have to worry about distributing it.

Comment 7

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 8

[rctgamer3]

(In reply to Wim Brand from comment #6)

I think I have this issue too. I'm using Firefox 75.0 on Manjaro Linux.

When playing this FLAC file ( https://pixeldrain.com/u/46tg85mZ ) it crashes at exactly 1:07 every time. The song is royalty free, so you don't have to worry about distributing it.

The file you linked does not crash for me in "77.0b4 (64-bit)". The ones I linked still do crash the tab.

Comment 9

[Darkspirit]

comment 3: ESR: bp-e304839e-d1eb-497c-bf27-70d2c0200512, Nightly: bp-7aa76dd6-2284-482b-924d-916ca0200512
comment 5: ESR: bp-9ff51631-129a-477c-9065-7ca490200512, Nightly: bp-9c4bac60-717b-4000-8256-8dc400200512
comment 6: Firefox ESR on Debian Testing is affected (flac stops playing at 1m7s), Nightly is fine.

Comment 10

[Wim Brand]

I upgraded to Firefox 76 and now I can't reproduce it anymore. I can't make the tab crash with the Animal Crossing song either.

Comment 11

[rctgamer3]

I'm using 77.0b9 now and these FLACs still cause tab crashes.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.

Comment 13

[Michael Lelli]

I've just hit these same crashes on the examples provided in the comments. This one's still up and still crashes on seek for me: https://nookipedia.com/w/images/8/8a/NH_BGM_Audio_053_Kekesong_Hifi.flac

Nightly 89.0a1 build id 20210417214426
Windows 10 64-bit

Should this issue be re-opened, or should a new bug be made?

Comment 14

[Michael Lelli]

I looked at the file that caused a crash, and it might be subtly corrupted in some way, or at least encoded weirdly. It has this following metadata:

type: 0 (STREAMINFO)
is last: true
length: 34
minimum blocksize: 16 samples
maximum blocksize: 65535 samples
minimum framesize: 0 bytes
maximum framesize: 0 bytes
sample_rate: 48000 Hz
channels: 1
bits-per-sample: 16
total samples: 792240
MD5 signature: 47a07b53ac74293ba01fbc05e6e206bb

If I re-encode it with flac 1.3.2, I get this metadata:

type: 0 (STREAMINFO)
is last: true
length: 34
minimum blocksize: 4096 samples
maximum blocksize: 4096 samples
minimum framesize: 703 bytes
maximum framesize: 4443 bytes
sample_rate: 48000 Hz
channels: 1
bits-per-sample: 16
total samples: 792240
MD5 signature: 47a07b53ac74293ba01fbc05e6e206bb

The big difference is the vastly bigger range for blocksize, and the min/max framesizes are no longer both 0.

Comment 15

[rctgamer3]

Reopening since this is a rare crash but has easy steps to reproduce.

Comment 16

[Chris Peterson [:cpeterson]]

Unassigning bugs assigned to Bryce because he no longer works at Mozilla.