Closed
Bug 1628356
Opened 4 years ago
Closed 4 years ago
Remove toolkit search.svg and use browser search-glass.svg instead
Categories
(Toolkit :: Themes, task)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla77
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: ntim, Assigned: aarushivij, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
They're exactly the same SVG. The toolkit SVG has only one usage in browser/, so let's remove that one.
To fix this bug:
- Run
hg rm toolkit/themes/shared/icons/search.svg
- Remove the corresponding line from toolkit/themes/shared/jar.inc.mn
- Replace this usage (https://searchfox.org/mozilla-central/rev/a707541ff423ade0d81cef6488e6ecfa09273886/browser/components/aboutlogins/content/components/login-filter.css#10) with
chrome://browser/skin/search-glass.svg
Assignee | ||
Comment 1•4 years ago
|
||
Hello, Can I submit the patch ?
Thanks :)
Aarushi
Reporter | ||
Comment 2•4 years ago
|
||
Please go ahead :)
Assignee | ||
Comment 3•4 years ago
|
||
Updated•4 years ago
|
Assignee: nobody → aarushivij
Status: NEW → ASSIGNED
Updated•4 years ago
|
Attachment #9139388 -
Attachment description: Bug 1628356 - Remove toolkit search.svg and use browser search-glass.svg instead r=ntim → Bug 1628356 - Remove toolkit search.svg and use browser search-glass.svg instead. r=ntim
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/31361f4c475f Remove toolkit search.svg and use browser search-glass.svg instead. r=ntim
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•