1628358 - Remove unused search.svg image in JSON viewer

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, task, P3)

Description

[Tim Nguyen :ntim]

Steps to fix this:

• Run hg rm devtools/client/jsonview/css/search.svg
• remove https://searchfox.org/mozilla-central/source/devtools/client/jsonview/css/moz.build#13

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report and instructions Tim!
Honza

Comment 2

[Harshil]

I would to take this.

Comment 3

[Harshil]

(In reply to Harshil from comment #2)

I would like to take this.

Comment 4

[Tim Nguyen :ntim]

(In reply to Harshil from comment #2)

I would to take this.

Please feel free to submit a patch, let me know if you have questions!

Comment 5

[Harshil]

Hey :ntim,
Thank you. I've made the changes as instructed. To make sure I am following the correct contribution flow, I am following the docs, but still wanted to confirm it once with you.
We don't create a separate branch, and once we make the changes we commit them with following the commit message structure, right? Also in the reviewer should it be you, ntim?

Comment 6

[Tim Nguyen :ntim]

(In reply to Harshil from comment #5)

Hey :ntim,
Thank you. I've made the changes as instructed. To make sure I am following the correct contribution flow, I am following the docs, but still wanted to confirm it once with you.

Thanks for working on this!

We don't create a separate branch, and once we make the changes we commit them with following the commit message structure, right? Also in the reviewer should it be you, ntim?

Yes, commit them first and then submit them to Phabricator for review using the moz-phab command.

The commit message can be:
"Bug 1628358 - Remove unused search.svg image in JSON viewer. r=ntim`.

Happy to review this change!

Comment 7

[Harshil]

Hey :ntim,

Thanks for the help. I am facing some issues with mercurial. Can I message you Slack?

Thanks.

Comment 8

[Tim Nguyen :ntim]

(In reply to Harshil from comment #7)

Hey :ntim,

Thanks for the help. I am facing some issues with mercurial. Can I message you Slack?

Thanks.

I mostly use https://chat.mozilla.org/ rather than the DevTools Slack, but feel free to message me there.

Comment 9

[Harshil]

Attachment: Bug 1628358 - Remove unused search.svg image in JSON viewer. r=ntim

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e9ea7b13371
Remove unused search.svg image in JSON viewer. r=Honza

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7e9ea7b13371