Closed Bug 1628365 Opened 6 years ago Closed 6 years ago

One off search separator remains visible when all one off engines are hidden/disabled

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Version:
75 Branch
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: klk745, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Went to about:config and set browser.urlbar.oneOffSearches to false in order to prevent the display of non-default search engines as optional choice. The display of other suggestions from the bookmarks or history are disbled as well.

Actual results:

The search engine content is gone, but there's still a thin grey line that appears when I enter something into the address bar.

Expected results:

The grey border line should not appear as well when there's nothing to display/suggest. I'm using FF 75.0 on Ubuntu 18.04 LTS.

Unchecking all one-click search engines in about:preferences#search results in the same bug.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Search
Component: Search → Address Bar

To ensure that it is not related to a broken profile, I installed a completely fresh Kubuntu Focal with FF 75.0 in a VM.
The horizontal grey line is being displayed there, too.

Sorry, but I'm going to wontfix this because we don't support disabling that pref and in fact we should remove it. I filed bug 1628926.

Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX

The bug persists when browser.urlbar.oneOffSearches is set to true and all one-click search engines in about:preferences#search are unchecked as pointed out in comment #1 by me.

Sorry, I missed that.

Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: WONTFIX → ---
Status: REOPENED → NEW
Priority: -- → P3
Summary: UI bug when browser.urlbar.oneOffSearches is set to false → One off search separator remains visible when all one off engines are hidden/disabled

I can't reproduce this. Based on your comments, I set the following prefs to false. Am I missing any? Could you please post a screenshot of what you're seeing?

browser.urlbar.oneOffSearches
browser.urlbar.suggest.bookmark
browser.urlbar.suggest.history
browser.urlbar.suggest.openpage
browser.urlbar.suggest.searches
browser.search.suggest.enabled
browser.search.suggest.enabled.private
Flags: needinfo?(klk745)

I see bug 1628926 now, back to wontfix.

Status: NEW → RESOLVED
Closed: 6 years ago → 6 years ago
Flags: needinfo?(klk745)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.