1628379 - Prevent browsertime from continuing chrome tests if chromedriver doesn't exist

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P2)

Description

[Greg Mierzwinski [:sparky]]

There are failures that aren't very clear occurring where the chromedriver doesn't exist, but we continue to try to run browsertime anyway - we should check if the driver exists before continuing with the test: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=8902199bcf7a3baf2279b972b0d336a7e794bb63&selectedJob=296809238

Comment 1

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1628379 - Make browsertime fail early if chromedriver doesn't exist. r?#perftest

Some phones aren't updating their google-chrome version so we are hitting issues where the chromedriver is not being found because it's looking for an older version. This patch makes the error occur earlier and prevents browsertime from running if we hit it.

Comment 2

[Andrew Erickson [:aerickson]]

If you exit with code 4, Android jobs are configured to retry the job.

Comment 3

[Andrew Erickson [:aerickson]]

It would be cool if the test code printed the version of Chrome it's testing. I think the following should do it.

adb shell dumpsys package my.package | grep versionName // I think that this is the human readable string.
adb shell dumpsys package my.package | grep versionCode // I think this is an integer that always increases.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91466c558e04
Make browsertime fail early if chromedriver doesn't exist. r=perftest-reviewers,AlexandruIonescu

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/91466c558e04