Closed Bug 162851 Opened 22 years ago Closed 22 years ago

Add universal charset detector

Categories

(Camino Graveyard :: General, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Chimera0.5

People

(Reporter: mikepinkerton, Assigned: mikepinkerton)

Details

We need to do 3 things to add the universal charset detector to the build:

- build with the extension. this means changing everyone's .mozconfig including
the tinderboxen and the nightly build machine
- add the library to the build (dylib and static)
- add user_pref("intl.charset.detector", "universal_charset_detector"); somewhere.

where is a good place to put this pref? we can't put it into all.js because we
couldn't land that on the trunk.
i have this working on my build (dylib), but it causes mozilla.org to use a
different character set. i think it's falling back to atsui. ppembed doesn't
have this problem.

simon, any ideas?
Target Milestone: --- → Chimera0.5
i appear to be on crack. i pitched my cache and now everything is fine.
when we move to the new branch, you'll find we have "chimera.js" (thanks bryner!)

cc mcafee since we're talking about changing tinderboxen
internal test page for universal charset detector.
Status: NEW → ASSIGNED
What internal test page?  ;)
let me know what the extension is and when we need to add it, and I can make
that happen.
the extension is "universalchardet"
static build changes are checked in.
packaging changes are in, dylib changes are in. now all we need is to set the
pref. ftang suggests doing it in navigator.properties, but we can't do it there
because that file is shared by seamonkey (so we could never land that on the
trunk). 

i suggest setting it as a user_pref in chimera.js so it's on for all locales.
In v1.105 of the project file (change made as part of this bug), someone added
"/Volumes/Data/Source/cocoazilla/mozilla/dist/Embed/components" as one of the
library search paths.  I don't think that path exists on most people's systems :)

At the same time, my builds of chimera have been broken all day (will start up,
but won't load any pages).  I'm still trying to figure out why.  Changing the
search path above to '../dist/Embed/components" + a recompile didn't fix it
right away, so I'm not sure thats the problem.
pref landed in code. we always use it now.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.