1628628 - Perma Windows asan tier-3 TestDllBlocklist.NoOpEntryPoint | Value of: !!hDll

Status: RESOLVED FIXED

(Firefox :: Launcher Process, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=296845006&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PkJMu4bbQ0OOVyrE-xCNcA/runs/0/artifacts/public/logs/live_backing.log

---

Started with bug 1603974's patches.

[task 2020-04-08T21:27:59.518Z] 21:27:59 INFO - TEST-START | TestDllBlocklist.NoOpEntryPoint
[task 2020-04-08T21:27:59.518Z] 21:27:59 INFO - LdrLoadDll: Blocking load of 'testdllblocklist_noopentrypoint.dll' -- see http://www.mozilla.com/en-US/blocklist/
[task 2020-04-08T21:27:59.519Z] 21:27:59 WARNING - TEST-UNEXPECTED-FAIL | TestDllBlocklist.NoOpEntryPoint | Value of: !!hDll
[task 2020-04-08T21:27:59.519Z] 21:27:59 INFO - Actual: false
[task 2020-04-08T21:27:59.519Z] 21:27:59 INFO - Expected: true @ z:/build/build/src/mozglue/tests/gtest/TestDLLBlocklist.cpp:82
[task 2020-04-08T21:27:59.519Z] 21:27:59 WARNING - TEST-UNEXPECTED-FAIL | TestDllBlocklist.NoOpEntryPoint | Value of: !!::GetModuleHandleW(kLeafName.get())
[task 2020-04-08T21:27:59.519Z] 21:27:59 INFO - Actual: false
[task 2020-04-08T21:27:59.519Z] 21:27:59 INFO - Expected: true @ z:/build/build/src/mozglue/tests/gtest/TestDLLBlocklist.cpp:83
[task 2020-04-08T21:27:59.519Z] 21:27:59 WARNING - TEST-UNEXPECTED-FAIL | TestDllBlocklist.NoOpEntryPoint | test completed (time: 2ms)

Comment 1

[Toshihito Kikuchi [:toshi]]

With ASAN, TestDllBlocklist uses mozglue!patched_LdrLoadDll, where RedirectToNoOpEntryPoint behaves the same as DllBlocklistEntry, thus LoadLibrary returned nullptr. Given that the old blocklist cannot block a module in a process's early stage, I think this behavior is ok. We need to adjust the test.

Comment 2

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1628628 - RedirectToNoOpEntryPoint is expected to block a module with ASAN. r=mhowell

With ASAN, GTest uses the old blocklist implemented in mozglue, where
the new blocklist type RedirectToNoOpEntryPoint behaves the same as
DllBlocklistEntry. The test needs to expect LoadLibrary to fail.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2cf7e6e5a35
RedirectToNoOpEntryPoint is expected to block a module with ASAN.  r=mhowell

Comment 4

[Toshihito Kikuchi [:toshi]]

The reason why ASAN build picks the old blocklist is this; we purposely make InitializeDllBlocklistOOP no-op in ASAN build.

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b2cf7e6e5a35

Comment 6

[Intermittent Failures Robot]

1 failures in 4823 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1628628&startday=2020-04-06&endday=2020-04-12&tree=all