Use unified fragment pattern for toolkit/content/widgets/panel.js
Categories
(Toolkit :: UI Widgets, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: ntim, Assigned: aarushivij, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
Seems like panel.js could benefit from the unified pattern as well.
|
Reporter | |
Comment 1•4 years ago
|
||
It sounds like this could be a nice good first bug for a new contributor. Emma, what do you think?
|
||
Comment 2•4 years ago
|
||
Agreed!
For more context, we would like this class to now use static get fragment within customElement.js (https://searchfox.org/mozilla-central/source/toolkit/content/customElements.js#472-499).
|
Assignee | |
Comment 3•4 years ago
|
||
Hello Tim, Can I work on this bug?
Can you please elaborate what needs to be done?
Do we need to change https://searchfox.org/mozilla-central/search?q=get+fragment&case=false®exp=false&path=toolkit%2Fcontent%2Fwidgets%2Fpanel.js into static get fragment ?
Thank You :)
Aarushi
|
|
Reporter | |
Comment 4•4 years ago
•
|
||
(In reply to aarushivij from comment #3)
Hello Tim, Can I work on this bug?
Please go for it :)
Can you please elaborate what needs to be done?
Do we need to change https://searchfox.org/mozilla-central/search?q=get+fragment&case=false®exp=false&path=toolkit%2Fcontent%2Fwidgets%2Fpanel.js intostatic get fragment?
You should do the same thing for toolkit/content/widgets/panel.js
Please let Emma know if you've got any questions!
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/05f13ef2ba3f Use unified fragment pattern for toolkit/content/widgets/panel.js r=emalysz
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
Description
•