162866 - Clipboard copy and drag/drop not working in Mozilla 1.2 builds

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[ajbu]

Mozilla renamed supportsWString to supportsString (bug 157137)
This affects Calendar's clipboard functions, not working in recent 1.2 alpha 
builds

Comment 1

[Mike Potter]

We can take one of two paths here...
We can put if statements in the code, or we can start making builds for the
different versions of Mozilla....

Comment 2

[ajbu]

A good point to start making different builds would be the moment Calendar is 
build by default for Mozilla.
if statements might be ugly, but easier to maintain for you? I guess people 
must the pick the correct version from the website?

Comment 3

[Mike Potter]

We could also write some JS code that will look at their current version and
"suggest" the right version of the calendar for them.
For now, we won't worry about it, we should get a build that works very well on
Mozilla 1.0.

Comment 4

[Mike Potter]

Moving this off my plate, we'll do this when 1.2 becomes a released version.

Comment 5

[ajbu]

Is there a function to get the Mozilla version?
Otherwise I could make a some constants and a function mozillaVersion() that 
parses navigator.userAgent and return (MOZILLA_10 | MOZILLA_11 | MOZILLA_12 | 
MOZILLA_XX)
then in the code do a if( mozillaVersion() == MOZILLA_12 )

Is this acceptable, or are there cleaner ways to do this?

Comment 6

[Mike Potter]

I don't know anyway to get the Mozilla version off hand.
Those functions sound like a good idea to me, we may need them for some other
things.

Comment 7

[ajbu]

Attachment: patch for calendarClipboard.js

renames WString to String and String to CString for mozilla 1.2
(breaks clipboard support for Mozilla 1.0/1.1)

Comment 8

[Mike Potter]

Why do we need to add the last patch?  The dragging and dropping stuff works
fine for me in Mozilla 1.0 and Mozilla 1.2.

Comment 9

[ajbu]

Last patch is only for copy/paste of calendar Items, not drag/drop.
Try copy an event to the clipboard, and paste it back into calendar, this 
doesn't work for me on Mozilla 1.2.

Comment 10

[Mike Potter]

Sorry, its early in the morning here. :)
Patch applied fine to my tree, will check in after testing it out.

Comment 11

[Mike Potter]

This is checked into the tree.
I don't think that cut is working properly, the events are not being deleted for me.

Comment 12

[Mike Potter]

This is checked in, and everything is working fine for me.

Comment 13

[Brant Gurganus]

When I tried to cut an event, I received the following error:
Error: unifinderDeleteCommand is not defined
Source File: chrome://calendar/content/calendarClipboard.js
Line: 132

This isn't completely fixed unless you change the bug summary.  Drag/drop is not
working, which is in the summary.

2002103116-cal, WinXP, 2002110108

Comment 14

[Mike Potter]

This is fixed in CVS.

Comment 15

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!