Closed Bug 1628692 Opened 3 months ago Closed 2 months ago

FallibleTArray must not be copy-constructible/copy-assignable

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: sg, Assigned: sg)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(11 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

FallibleTArray must not be copy-constructible or copy-assignable. These operations may fail, but there's no way to signal this to the caller. Instead, named member functions with a fallible_t argument must be used instead to make the copy.

There are several uses of this, including in code generated by ipdlc, which must be fixed first or as part of this.

Component: MFBT → XPCOM
Depends on: 1631435
See Also: → 1628715
Blocks: 1631461
Assignee: nobody → sgiesecke
Status: NEW → ASSIGNED
Attachment #9141724 - Attachment description: Bug 1628692 - Make Sequence copyable for now. r=smaug → Bug 1628692 - Make Sequence infallibly copyable for now. r=smaug
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/624e19601244
Make Sequence infallibly copyable for now. r=smaug
https://hg.mozilla.org/integration/autoland/rev/187234687039
Fix FallibleTArray handling in gfxContext::CurrentDash. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/71e08c8c8989
Prepare dom/serviceworkers and dom/workers for making FallibleTArray uncopyable. r=dom-workers-and-storage-reviewers,edenchuang
https://hg.mozilla.org/integration/autoland/rev/5b584b2a5d4f
Prepare dom/crypto for making FallibleTArray uncopyable. r=keeler
https://hg.mozilla.org/integration/autoland/rev/a1490f1af74c
Prepare toolkit/components/url-classifier/ for making FallibleTArray uncopyable. r=gcp
https://hg.mozilla.org/integration/autoland/rev/d0842e4533ad
Prepare media/webrtc/signaling/src/peerconnection/ for making FallibleTArray uncopyable. r=jesup,bwc,erahm
https://hg.mozilla.org/integration/autoland/rev/1902866d724e
Prepare dom/webauthn for making FallibleTArray uncopyable. r=jcj
https://hg.mozilla.org/integration/autoland/rev/c32bca788054
Prepare dom/media for making FallibleTArray uncopyable. r=jya
https://hg.mozilla.org/integration/autoland/rev/b0a71249d010
Prepare dom/filesystem for making FallibleTArray uncopyable. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d09196735d07
Prepare dom/base for making FallibleTArray uncopyable. r=smaug
https://hg.mozilla.org/integration/autoland/rev/fa00c3d74a98
Make FallibleTArray uncopyable. r=xpcom-reviewers,nika
You need to log in before you can comment on or make changes to this bug.