1628748 - Switch to python3 seems to have broken the Compiler database backend

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andi [:andi]]

Running on macOS:

 ./mach build-backend -b CompileD

Results in:

 0:00.64 /Users/abpostelnicu/Projects/mozilla/obj-ff-osx/_virtualenvs/init_py3/bin/python /Users/abpostelnicu/Projects/mozilla/obj-ff-osx/config.status --backend CompileDB
Reticulating splines...
Traceback (most recent call last):
  File "/Users/abpostelnicu/Projects/mozilla/obj-ff-osx/config.status", line 905, in <module>
    config_status(**args)
  File "/Users/abpostelnicu/Projects/mozilla/mozilla-unified/python/mozbuild/mozbuild/config_status.py", line 148, in config_status
    the_backend.consume(definitions)
  File "/Users/abpostelnicu/Projects/mozilla/mozilla-unified/python/mozbuild/mozbuild/backend/base.py", line 129, in consume
    if (not self.consume_object(obj) and
  File "/Users/abpostelnicu/Projects/mozilla/mozilla-unified/python/mozbuild/mozbuild/compilation/database.py", line 67, in consume_object
    obj.canonical_suffix)
  File "/Users/abpostelnicu/Projects/mozilla/mozilla-unified/python/mozbuild/mozbuild/compilation/database.py", line 213, in _build_db_line
    append_var('OS_COMPILE_CMMFLAGS')
  File "/Users/abpostelnicu/Projects/mozilla/mozilla-unified/python/mozbuild/mozbuild/compilation/database.py", line 204, in append_var
    if isinstance(value, types.string_types):
AttributeError: module 'types' has no attribute 'string_types'

This is because string_types no longer exists in types.

Comment 1

[Andi [:andi]]

Attachment: Bug 1628748 - Switch to python3 seems to have broken the Compiler database backend. r=sylvestre

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ccb606f2be5
Switch to python3 seems to have broken the Compiler database backend. r=sylvestre

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/8ccb606f2be5