Closed Bug 1628755 Opened 4 years ago Closed 4 years ago

Beta as Release Intermittent toolkit/components/extensions/test/xpcshell/test_ext_privacy.js | test_privacy_other_prefs - [test_privacy_other_prefs : 386] Got expected result on setting network.tlsVersionRestriction

Categories

(WebExtensions :: General, defect, P1)

Product:
WebExtensions
Component:
General
Type:
defect

Tracking

(firefox-esr68 unaffected, firefox74 unaffected, firefox75 unaffected, firefox76+ verified, firefox77+ verified)

Status:
VERIFIED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- unaffected
firefox75 --- unaffected
firefox76 + verified
firefox77 + verified

People

(Reporter: aciure, Assigned: baku)

References

Details

Attachments

(2 files)

Bug 1628755 - Better min/max TLS versions pref handling in the webExtension privacy API, r?mixedpuppy
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 1628755 - Fix test_ext_privacy.js xpcshell-test failure in beta, r=mixedpuppy
47 bytes, text/x-phabricator-request
Details | Review

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296932491&repo=try&lineNumber=41382

[task 2020-04-09T12:39:11.242Z] 12:39:11 INFO - TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_privacy.js
[task 2020-04-09T12:39:13.583Z] 12:39:13 WARNING - TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_privacy.js | xpcshell return code: 0
[task 2020-04-09T12:39:13.583Z] 12:39:13 INFO - TEST-INFO took 2343ms
[task 2020-04-09T12:39:13.583Z] 12:39:13 INFO - >>>>>>>
[task 2020-04-09T12:39:13.590Z] 12:39:13 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-04-09T12:39:13.590Z] 12:39:13 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2020-04-09T12:39:13.591Z] 12:39:13 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-04-09T12:39:13.591Z] 12:39:13 INFO - running event loop
[task 2020-04-09T12:39:13.592Z] 12:39:13 INFO - xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_privacy.js | Starting check_remote
[task 2020-04-09T12:39:13.592Z] 12:39:13 INFO - (xpcshell/head.js) | test check_remote pending (2)
[task 2020-04-09T12:39:13.592Z] 12:39:13 INFO - TEST-PASS | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_privacy.js | check_remote - [check_remote : 1] useRemoteWebExtensions matches - true == true
[task 2020-04-09T12:39:13.593Z] 12:39:13 INFO - TEST-PASS | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_privacy.js | check_remote - [check_remote : 1] testing from extension process - false == false
[task 2020-04-09T12:39:13.593Z] 12:39:13 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2020-04-09T12:39:13.593Z] 12:39:13 INFO - (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2020-04-09T12:39:13.594Z] 12:39:13 INFO - (xpcshell/head.js) | test check_remote finished (2)
[task 2020-04-09T12:39:13.594Z] 12:39:13 INFO - xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_privacy.js | Starting test_privacy
[task 2020-04-09T12:39:13.595Z] 12:39:13 INFO - (xpcshell/head.js) | test test_privacy pending (2)
[task 2020-04-09T12:39:13.595Z] 12:39:13 INFO - PID 5916 | 1586435951447 addons.manager DEBUG Application has been upgraded
[task 2020-04-09T12:39:13.595Z] 12:39:13 INFO - PID 5916 | 1586435951448 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider", "XPIInternal"]
[task 2020-04-09T12:39:13.596Z] 12:39:13 INFO - PID 5916 | 1586435951451 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm
[task 2020-04-09T12:39:13.596Z] 12:39:13 INFO - PID 5916 | 1586435951452 addons.manager DEBUG Loaded provider scope for resource://gre/modules/addons/PluginProvider.jsm
[task 2020-04-09T12:39:13.596Z] 12:39:13 INFO - PID 5916 | 1586435951453 addons.manager DEBUG Starting provider: XPIProvider
[task 2020-04-09T12:39:13.597Z] 12:39:13 INFO - PID 5916 | 1586435951453 addons.xpi DEBUG startup
[task 2020-04-09T12:39:13.597Z] 12:39:13 INFO - PID 5916 | 1586435951453 addons.xpi DEBUG List of valid built-in add-ons could not be parsed.: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: startup :: line 2394" data: no] Stack trace: startup()@resource://gre/modules/addons/XPIProvider.jsm:2394
[task 2020-04-09T12:39:13.597Z] 12:39:13 INFO - PID 5916 | callProvider()@resource://gre/modules/AddonManager.jsm:215
[task 2020-04-09T12:39:13.598Z] 12:39:13 INFO - PID 5916 | _startProvider()@resource://gre/modules/AddonManager.jsm:587
[task 2020-04-09T12:39:13.598Z] 12:39:13 INFO - PID 5916 | startup()@resource://gre/modules/AddonManager.jsm:811
[task 2020-04-09T12:39:13.599Z] 12:39:13 INFO - PID 5916 | startup()@resource://gre/modules/AddonManager.jsm:3482
[task 2020-04-09T12:39:13.599Z] 12:39:13 INFO - PID 5916 | observe()@resource://gre/modules/addonManager.js:87
[task 2020-04-09T12:39:13.599Z] 12:39:13 INFO - PID 5916 | promiseStartupManager()@resource://testing-common/AddonTestUtils.jsm:979
[task 2020-04-09T12:39:13.599Z] 12:39:13 INFO - PID 5916 | test_privacy()@Z:/task_1586434624/build/tests/xpcshell/tests/toolkit/components/extensions/test/xpcshell/test_ext_privacy.js:94
[task 2020-04-09T12:39:13.600Z] 12:39:13 INFO - PID 5916 | _run_next_test/<()@Z:\task_1586434624\build\tests\xpcshell\head.js:1567
[task 2020-04-09T12:39:13.600Z] 12:39:13 INFO - PID 5916 | _run_next_test()@Z:\task_1586434624\build\tests\xpcshell\head.js:1567
[task 2020-04-09T12:39:13.601Z] 12:39:13 INFO - PID 5916 | run()@Z:\task_1586434624\build\tests\xpcshell\head.js:735
[task 2020-04-09T12:39:13.601Z] 12:39:13 INFO - PID 5916 | _do_main()@Z:\task_1586434624\build\tests\xpcshell\head.js:246
[task 2020-04-09T12:39:13.601Z] 12:39:13 INFO - PID 5916 | _execute_test()@Z:\task_1586434624\build\tests\xpcshell\head.js:573

[Tracking Requested - why for this release]:

status-firefox76: --- → affected
status-firefox77: --- → affected
tracking-firefox76: --- → ?
Summary: Beta as Release toolkit/components/extensions/test/xpcshell/test_ext_privacy.js | test_privacy_other_prefs - [test_privacy_other_prefs : 386] Got expected result on setting network.tlsVersionRestriction → Beta as Release Intermittent toolkit/components/extensions/test/xpcshell/test_ext_privacy.js | test_privacy_other_prefs - [test_privacy_other_prefs : 386] Got expected result on setting network.tlsVersionRestriction

I think that the link in comment 0 is wrong. I found: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296949727&repo=try&lineNumber=7602

That looks like there is a test in the underlying code. What appears to be happening is that attempting to set the maximum value to a value lower than our limit is working.

Baku, this is your code. Am I reading that correctly?

Flags: needinfo?(mt) → needinfo?(amarchesini)

There a few bugs in this test and in how we set the min/max TLS version prefs.

Flags: needinfo?(amarchesini)
Assignee: nobody → amarchesini
Priority: -- → P1
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9afdf7a5616a
Better min/max TLS versions pref handling in the webExtension privacy API, r=mixedpuppy

https://hg.mozilla.org/mozilla-central/rev/9afdf7a5616a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(amarchesini)

Comment on attachment 9140377 [details]
Bug 1628755 - Better min/max TLS versions pref handling in the webExtension privacy API, r?mixedpuppy

Beta/Release Uplift Approval Request

  • User impact if declined: extensions receive an unpredictable behavior when settings the min/max TLS version
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This extension API is only available for privileged extensions. Low risk.
  • String changes made/needed:
Flags: needinfo?(amarchesini)
Attachment #9140377 - Flags: approval-mozilla-beta?

Comment on attachment 9140377 [details]
Bug 1628755 - Better min/max TLS versions pref handling in the webExtension privacy API, r?mixedpuppy

Fixes a test permafail when 76 merges to release next week. Approved for 76.0b8.

Attachment #9140377 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7013b18788c1
Fix test_ext_privacy.js xpcshell-test failure in beta, r=mixedpuppy

https://hg.mozilla.org/mozilla-central/rev/7013b18788c1

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox77: affected → fixed
Resolution: --- → FIXED

Verified fixed on mozilla-release.

Status: RESOLVED → VERIFIED
status-firefox76: fixed → verified
status-firefox77: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: