1628871 - Make media.eme.enabled locking work properly

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

Currently we have a pref to turn off media.eme.enabled, but the locked state is ignored by Firefox.

We should implement a proper policy with locking/unlocking and add the check in MediaKeySystemAccessManager.cpp

-    MediaKeySystemAccess::NotifyObservers(mWindow, aRequest->mKeySystem,
-                                          MediaKeySystemStatus::Api_disabled);
+    if (!Preferences::IsLocked("media.eme.enabled")) {
+      MediaKeySystemAccess::NotifyObservers(mWindow, aRequest->mKeySystem,
+                                            MediaKeySystemStatus::Api_disabled);
+    }

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1628871 - Don't show DRM install message if eme pref is locked. r?bryce

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1628871 - Add policy for Encrypted Media Extensions. r?mconley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e560ed2592e
Don't show DRM install message if eme pref is locked. r=bryce

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/3e560ed2592e

Comment 5

[Mike Kaply [:mkaply]]

Forgot to mark leave open.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74d737283c49
Add policy for Encrypted Media Extensions. r=mconley,fluent-reviewers,flod

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/74d737283c49

Comment 8

[Mike Kaply [:mkaply]]

Attachment: ESR version of first patch

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fix to make policy work properly
User impact if declined: When EME pref is locked, UI shows but doesn't work.
Fix Landed on Version: 77
Risk to taking this patch (and alternatives if risky): Low, test and only kicks in if policy is set.

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 9

[Mike Kaply [:mkaply]]

Comment on attachment 9140267 [details]
Bug 1628871 - Add policy for Encrypted Media Extensions. r?mconley

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: New policy
• User impact if declined: Policy unavailable
• Fix Landed on Version: 77
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only
• String or UUID changes made by this patch: New policy string.

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9145944 [details] [diff] [review]
ESR version of first patch

new policy, approved for 68.9

Comment 11

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/20de7a699084
https://hg.mozilla.org/releases/mozilla-esr68/rev/84c0d49497b0

Comment 12

[Julien Cristau [:jcristau]]

Attachment: Bug 1628871 - followup: fix test for esr68. r?mkaply

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/77897237c7a8