1628927 - Convert symbolstore.py to python 3

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1628927 - Convert symbolstore.py to python 3.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/789cef4e9c6d
Convert symbolstore.py to python 3. r=rstewart

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for bustages related to symbols.

backout: https://hg.mozilla.org/integration/autoland/rev/06ee15775ba8511ff1784027c7bfde2fc745a490

Push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C2012%2Cx64%2Cdebug%2Cbuild-win64-fuzzing%2Fdebug%2C%28bf%29&revision=789cef4e9c6d435426565b64f6ba8733d1ee6244&selectedJob=297204070

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297204070&repo=autoland&lineNumber=40850

[task 2020-04-11T01:18:19.349Z] 01:18:19 INFO - Processing file: z:\build\workspace\obj-build\accessible\interfaces\msaa\AccessibleMarshal.dll
[task 2020-04-11T01:18:19.351Z] 01:18:19 INFO - z:\build\fetches\dump_syms\dump_syms.exe z:\build\workspace\obj-build\accessible\interfaces\msaa\AccessibleMarshal.dll
[task 2020-04-11T01:18:19.352Z] 01:18:19 INFO - Unexpected error: Can't mix strings and bytes in path components
[task 2020-04-11T01:18:19.352Z] 01:18:19 ERROR - Traceback (most recent call last):
[task 2020-04-11T01:18:19.352Z] 01:18:19 INFO - File "z:/build/build/src\toolkit\crashreporter\tools\symbolstore.py", line 983, in <module>
[task 2020-04-11T01:18:19.352Z] 01:18:19 INFO - main()
[task 2020-04-11T01:18:19.352Z] 01:18:19 INFO - File "z:/build/build/src\toolkit\crashreporter\tools\symbolstore.py", line 979, in main
[task 2020-04-11T01:18:19.353Z] 01:18:19 INFO - dumper.Process(args[2], options.count_ctors)
[task 2020-04-11T01:18:19.353Z] 01:18:19 INFO - File "z:/build/build/src\toolkit\crashreporter\tools\symbolstore.py", line 488, in Process
[task 2020-04-11T01:18:19.353Z] 01:18:19 INFO - self.ProcessFile(file_to_process, count_ctors=count_ctors)
[task 2020-04-11T01:18:19.353Z] 01:18:19 INFO - File "z:/build/build/src\toolkit\crashreporter\tools\symbolstore.py", line 503, in ProcessFile
[task 2020-04-11T01:18:19.353Z] 01:18:19 INFO - count_ctors=count_ctors)
[task 2020-04-11T01:18:19.353Z] 01:18:19 INFO - File "z:/build/build/src\toolkit\crashreporter\tools\symbolstore.py", line 559, in ProcessFileWork
[task 2020-04-11T01:18:19.353Z] 01:18:19 INFO - (filename, rootname) = GetVCSFilename(filename, self.srcdirs)
[task 2020-04-11T01:18:19.354Z] 01:18:19 INFO - File "z:/build/build/src\toolkit\crashreporter\tools\symbolstore.py", line 338, in GetVCSFilename
[task 2020-04-11T01:18:19.354Z] 01:18:19 INFO - fileInfo = GetVCSFilenameFromSrcdir(file, srcdir)
[task 2020-04-11T01:18:19.354Z] 01:18:19 INFO - File "z:/build/build/src\toolkit\crashreporter\tools\symbolstore.py", line 308, in GetVCSFilenameFromSrcdir
[task 2020-04-11T01:18:19.354Z] 01:18:19 INFO - if os.path.isdir(os.path.join(srcdir, '.hg')):
[task 2020-04-11T01:18:19.354Z] 01:18:19 INFO - File "z:\build\workspace\obj-build_virtualenvs\init_py3\lib\ntpath.py", line 115, in join
[task 2020-04-11T01:18:19.355Z] 01:18:19 INFO - genericpath._check_arg_types('join', path, *paths)
[task 2020-04-11T01:18:19.355Z] 01:18:19 INFO - File "z:\build\workspace\obj-build_virtualenvs\init_py3\lib\genericpath.py", line 151, in _check_arg_types
[task 2020-04-11T01:18:19.355Z] 01:18:19 INFO - raise TypeError("Can't mix strings and bytes in path components") from None
[task 2020-04-11T01:18:19.355Z] 01:18:19 ERROR - TypeError: Can't mix strings and bytes in path components
[task 2020-04-11T01:18:19.355Z] 01:18:19 ERROR - Traceback (most recent call last):
[task 2020-04-11T01:18:19.355Z] 01:18:19 INFO - File "C:\mozilla-build\python3\Lib\runpy.py", line 193, in _run_module_as_main
[task 2020-04-11T01:18:19.356Z] 01:18:19 INFO - "main", mod_spec)
[task 2020-04-11T01:18:19.356Z] 01:18:19 INFO - File "C:\mozilla-build\python3\Lib\runpy.py", line 85, in _run_code
[task 2020-04-11T01:18:19.356Z] 01:18:19 INFO - exec(code, run_globals)
[task 2020-04-11T01:18:19.356Z] 01:18:19 INFO - File "z:\build\build\src\python\mozbuild\mozbuild\action\dumpsymbols.py", line 106, in <module>
[task 2020-04-11T01:18:19.356Z] 01:18:19 INFO - sys.exit(main(sys.argv[1:]))
[task 2020-04-11T01:18:19.356Z] 01:18:19 INFO - File "z:\build\build\src\python\mozbuild\mozbuild\action\dumpsymbols.py", line 102, in main
[task 2020-04-11T01:18:19.356Z] 01:18:19 INFO - args.count_ctors)
[task 2020-04-11T01:18:19.356Z] 01:18:19 INFO - File "z:\build\build\src\python\mozbuild\mozbuild\action\dumpsymbols.py", line 83, in dump_symbols
[task 2020-04-11T01:18:19.357Z] 01:18:19 INFO - out_files = subprocess.check_output(args, universal_newlines=True)
[task 2020-04-11T01:18:19.357Z] 01:18:19 INFO - File "C:\mozilla-build\python3\Lib\subprocess.py", line 336, in check_output
[task 2020-04-11T01:18:19.357Z] 01:18:19 INFO - **kwargs).stdout
[task 2020-04-11T01:18:19.357Z] 01:18:19 INFO - File "C:\mozilla-build\python3\Lib\subprocess.py", line 418, in run
[task 2020-04-11T01:18:19.357Z] 01:18:19 INFO - output=stdout, stderr=stderr)
[task 2020-04-11T01:18:19.357Z] 01:18:19 INFO - subprocess.CalledProcessError: Command '['z:\build\workspace\obj-build\_virtualenvs\init_py3\Scripts\python.exe', 'z:/build/build/src\toolkit\crashreporter\tools\symbolstore.py', '-c', '--vcs-info', '-i', '--install-manifest=z:/build/workspace/obj-build\_build_manifests\install\dist_include,z:/build/workspace/obj-build\dist\include', '-s', 'z:/build/build/src', 'z:/build/fetches/dump_syms/dump_syms.exe', 'z:/build/workspace/obj-build\dist\crashreporter-symbols', 'z:\build\workspace\obj-build\accessible\interfaces\msaa\AccessibleMarshal.dll']' returned non-zero exit status 1.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f09ef9c6f56a
Convert symbolstore.py to python 3. r=rstewart

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/f09ef9c6f56a