1629116 - Identify any additions to sync telemetry we want for rust-webext-storage (and future rust sync engines)

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

At a minimum this is probably:

• A flag that the user has the rust sync engine enabled.
• Very likely some new telemetry error types.
• Some way of determining the version of the rust components.
• Any telemetry needed for us to gain confidence in sync/merge algorithms. Probably conflict counts and such.

These are mostly small, and can either land together or in their own bug.

This is just the sync ping changes.

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1629116 - Add an overrideTelemetryName to bridged extension storage. r?markh

Add an overrideTelemetryName to bridged extension storage.

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

The patch that's up is simpler than the listed description as:

• New telemetry error types are covered by Bug 1634483
• Rust component version can be determined by firefox version / buildid
• Existing sync telemetry seems sufficient for merge info (already have some info in the ping around this).

This leaves the flag, but we can just do it via the overrideTelemetryName much more safely and with less churn.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89b2ab5018a8
Add an overrideTelemetryName to bridged extension storage. r=markh

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/89b2ab5018a8

Comment 5

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 9154407 [details]
Bug 1629116 - Add an overrideTelemetryName to bridged extension storage. r?markh

Beta/Release Uplift Approval Request

• User impact if declined: Errors in the new extension-storage sync would be masked due an inability to distinguish between problems in the (old) extension-storage engine and the (new) rust-based extension storage engine it replaces.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: N/A
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a very small change to change the name of an engine in sync telemetry. The change is entirely limited to sync telemetry
• String changes made/needed: N/A

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9154407 [details]
Bug 1629116 - Add an overrideTelemetryName to bridged extension storage. r?markh

approved for 78.0b5

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ccadffbc43df

Comment 8

[Julien Cristau [:jcristau]]

There's a test failure on beta can you take a look?
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305479153&repo=mozilla-beta&lineNumber=3069

Comment 9

[Thom Chiovoloni [:tcsc] (ex-moco)]

oh no! looking.

Comment 10

[Thom Chiovoloni [:tcsc] (ex-moco)]

I have a fix for this but am unsure what the process is for getting it up. Do I submit to phab again? attach a patch?

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Submit a new phab revision, please. And request beta approval if it touches more than tests. Thank you in advance.

Comment 12

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1629116 - Ensure the sync engine we want telemetry from is actually registered in tests. r?lina

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae2a0ff04460
Ensure the sync engine we want telemetry from is actually registered in tests. r=lina

Comment 14

[Thom Chiovoloni [:tcsc] (ex-moco)]

Okay, that fixes it. It's only tests.

Comment 15

[Thom Chiovoloni [:tcsc] (ex-moco)]

Should be good now, meant to ni.

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/c58fcde0eb82

Comment 17

[Julien Cristau [:jcristau]]

Thanks!

Comment 18

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ae2a0ff04460