Closed Bug 1629179 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 22860 - Handle k-rate AudioParam inputs for DynamicsCompressorNode

Categories

(Core :: Web Audio, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22860 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22860
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Handle k-rate AudioParam inputs for DynamicsCompressorNode

Support k-rate input to the AudioParms for a DynamicsCompressorNode.
The node only has k-rate AudioParams so we just need to make sure the
input is used.

Manually ran this test on Chrome stable, and all tests fail as
expected since k-rate inputs are not working there.

Bug: 1015760
Test: k-rate-dynamics-compressor-connections.html
Change-Id: I9ddaf27be5f2fef65f394f3d63f1fa8998c0ed82
Reviewed-on: https://chromium-review.googlesource.com/2145814
WPT-Export-Revision: 8756905d75b9aafd1d7bc437e3895aeae9954d2a

Component: web-platform-tests → Web Audio
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 72 tests

Status Summary

Firefox

OK : 1
PASS: 60[GitHub] 131[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 3

Chrome

OK : 1
PASS: 52
FAIL: 11

Safari

OK : 1
PASS: 8
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections.html
X k-rate threshold AudioParam with input does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
Index Actual Expected AbsError RelError Test threshold
[2432] -1.2464844621717930e-2 -1.2467551045119762e-2 2.7064234018325806e-6 2.1707738689323192e-4 0.0000000000000000e+0
[2433] -1.2221718207001686e-2 -1.2226036749780178e-2 4.3185427784919739e-6 3.5322507750270101e-4 0.0000000000000000e+0
[2434] -1.1524772271513939e-2 -1.1529812589287758e-2 5.0403177738189697e-6 4.3715522128277108e-4 0.0000000000000000e+0
[2435] -1.1310782283544540e-2 -1.1316668242216110e-2 5.8859586715698242e-6 5.2011409591496468e-4 0.0000000000000000e+0
[2436] -1.1019663885235786e-2 -1.1026103049516678e-2 6.4391642808914185e-6 5.8399275355708520e-4 0.0000000000000000e+0
...and 9560 more errors.
Max AbsError of 1.7780810594558716e-5 at index of 2523.
[2523] 2.0277552306652069e-2 2.0295333117246628e-2 1.7780810594558716e-5 8.7610341214103488e-4 0.0000000000000000e+0
Max RelError of 3.2533393817767632e-2 at index of 2579.
[2579] -2.8552167350426316e-6 -2.9512302717193961e-6 9.6013536676764488e-8 3.2533393817767632e-2 0.0000000000000000e+0
: FAIL
X k-rate threshold AudioParam with input does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
Index Actual Expected AbsError RelError Test threshold
[2432] -1.2464846484363079e-2 -1.2467551976442337e-2 2.7054920792579651e-6 2.1700267096299585e-4 0.0000000000000000e+0
[2433] -1.2221721000969410e-2 -1.2226040475070477e-2 4.3194741010665894e-6 3.5330114519694408e-4 0.0000000000000000e+0
[2434] -1.1524774134159088e-2 -1.1529818177223206e-2 5.0440430641174316e-6 4.3747810993947684e-4 0.0000000000000000e+0
[2435] -1.1310786008834839e-2 -1.1316673830151558e-2 5.8878213167190552e-6 5.2027843208062160e-4 0.0000000000000000e+0
[2436] -1.1019666679203510e-2 -1.1026107706129551e-2 6.4410269260406494e-6 5.8416143735472506e-4 0.0000000000000000e+0
...and 9560 more errors.
Max AbsError of 1.7777085304260254e-5 at index of 2523.
[2523] 2.0277557894587517e-2 2.0295334979891777e-2 1.7777085304260254e-5 8.7591977771608322e-4 0.0000000000000000e+0
Max RelError of 3.2567427641635026e-2 at index of 2579.
[2579] -2.8551585273817182e-6 -2.9512739274650812e-6 9.6115400083363056e-8 3.2567427641635026e-2 0.0000000000000000e+0
: FAIL
< [threshold] 1 out of 9 assertions were failed.: FAIL (Chrome: FAIL)
X k-rate threshold AudioParam with input does not equal [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of {"absoluteThreshold":0,"relativeThreshold":0}.
Index Actual Expected AbsError RelError Test threshold
[2432] -1.2464844621717930e-2 -1.2467551045119762e-2 2.7064234018325806e-6 2.1707738689323192e-4 0.0000000000000000e+0
[2433] -1.2221718207001686e-2 -1.2226036749780178e-2 4.3185427784919739e-6 3.5322507750270101e-4 0.0000000000000000e+0
[2434] -1.1524772271513939e-2 -1.1529812589287758e-2 5.0403177738189697e-6 4.3715522128277108e-4 0.0000000000000000e+0
[2435] -1.1310782283544540e-2 -1.1316668242216110e-2 5.8859586715698242e-6 5.2011409591496468e-4 0.0000000000000000e+0
[2436] -1.1019663885235786e-2 -1.1026103049516678e-2 6.4391642808914185e-6 5.8399275355708520e-4 0.0000000000000000e+0
...and 9558 more errors.
Max AbsError of 1.7780810594558716e-5 at index of 2523.
[2523] 2.0277552306652069e-2 2.0295333117246628e-2 1.7780810594558716e-5 8.7610341214103488e-4 0.0000000000000000e+0
Max RelError of 3.2533393817767632e-2 at index of 2579.
[2579] -2.8552167350426316e-6 -2.9512302717193961e-6 9.6013536676764488e-8 3.2533393817767632e-2 0.0000000000000000e+0
: FAIL

AUDIT TASK RUNNER FINISHED: 1 out of 5 tasks were failed.: FAIL

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bea7f4bce08
[wpt PR 22860] - Handle k-rate AudioParam inputs for DynamicsCompressorNode, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9fb6c336ec14
[wpt PR 22860] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e9670eb7c24
[wpt PR 22860] - Handle k-rate AudioParam inputs for DynamicsCompressorNode, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d56a11a4aaa6
[wpt PR 22860] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.