1629184 - Avoid needing to use clang-cl.exe under wine for MIDL

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P3)

Description

[(Away)]

Continuing from https://phabricator.services.mozilla.com/D70254:

A potential further followup might be: what if we get rid of the need for clang-cl.exe? MIDL could either use cl.exe to preprocess, or we could do our own preprocessing and pass /no_cpp. Then the "boring" cross builds (no PGO or sanitizers) could use the regular linux64-clang-9 toolchain. What do you think?

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1629184 - Preprocess MIDL inputs manually.

This avoids needing clang-cl.exe on cross compilations. We could keep
Windows builds on having MIDL do the preprocessing, but that would be
a difference between native and cross builds, and it's better to avoid
that.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1629184 - Remove clang-cl.exe from the linux64-clang-win-cross toolchain.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1629184 - Don't use the linux64-clang-win-cross in tasks that don't need it.

We don't need clang-cl.exe from the win-cross toolchain anymore, which
makes the remaining usecase for that toolchain to provide compiler
runtimes for e.g. asan or profiling. For any build that doesn't involve
those, we can use the plain clang toolchain.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f18120daf6e4
Preprocess MIDL inputs manually. r=firefox-build-system-reviewers,nalexander
https://hg.mozilla.org/integration/autoland/rev/e6bda575103e
Remove clang-cl.exe from the linux64-clang-win-cross toolchain. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/19b2d7c75eca
Don't use the linux64-clang-win-cross in tasks that don't need it. r=firefox-build-system-reviewers,andi

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f18120daf6e4
https://hg.mozilla.org/mozilla-central/rev/e6bda575103e
https://hg.mozilla.org/mozilla-central/rev/19b2d7c75eca