Closed Bug 1629196 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22863 - [FlexNG] Fix static position for abspos flex items

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22863 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22863
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[FlexNG] Fix static position for abspos flex items

Absolutely positioned flex items were getting placed wrong when the
containing block was legacy. This patch stores the relevant edges in
legacy and makes NG pick them up on the other side.

The above only works for abspos items controlled by NG. Legacy abspos
flex items with a legacy containing block, e.g.
position-absolute-009.html in this CL, still don't work.

Bug: 865235, 1066859
Change-Id: I3d6beb0bfe80292181b81d2e42bf79bf73ddc834

Reviewed-on: https://chromium-review.googlesource.com/2146133
WPT-Export-Revision: 93dd23df8129bc5b18833f5cb3b669242175b102

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 66 tests

Status Summary

Firefox

OK : 1
PASS: 102[GitHub] 161[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 1
PASS: 13
FAIL: 89

Safari

OK : 1
PASS: 70
FAIL: 32

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79fb2ecef9aa
[wpt PR 22863] - [FlexNG] Fix static position for abspos flex items, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/078821469f3a
[wpt PR 22863] - [FlexNG] Fix static position for abspos flex items, a=testonly

https://hg.mozilla.org/mozilla-central/rev/078821469f3a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.