Closed Bug 1629300 Opened 4 years ago Closed 4 years ago

--disable-optimize fails to build on Tier3 platforms

Categories

(Toolkit :: Crash Reporting, defect)

Unspecified
FreeBSD
defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

CrashReporter is not supported on Tier3 platforms. Removing -O appears to uncover bugs in stubs.

$ c++ --version
FreeBSD clang version 10.0.0 (git@github.com:llvm/llvm-project.git llvmorg-10.0.0-0-gd32170dbd5b)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin

$ echo "ac_add_options --disable-optimize" >>.mozconfig
$ ./mach bootstrap
$ ./mach build
[...]
toolkit/library/build/libxul.so
ld: error: undefined hidden symbol: CrashReporter::CreateNotificationPipeForChild(int*, int*)
>>> referenced by GeckoChildProcessHost.cpp:1163 (ipc/glue/GeckoChildProcessHost.cpp:1163)
>>>               ../../../ipc/glue/Unified_cpp_ipc_glue0.o:(mozilla::ipc::PosixProcessLauncher::DoSetup())

I'm submitting the patch for you.

Assignee: nobody → jbeich
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17c0b08918ac
Add back CreateNotificationPipeForChild for Tier3 after bug 1623961. r=KrisWright
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: