Closed Bug 1629301 Opened 4 years ago Closed 4 years ago

NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessenger.msgHdrFromURI] 3 mailWindowOverlay.js:1500

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect

Tracking

(thunderbird_esr68 fixed, thunderbird76 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 77.0
Tracking Flags:
Tracking Status
thunderbird_esr68 --- fixed
thunderbird76 --- fixed

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(1 file)

1629301-skip-bad-history.patch
1.07 KB, patch
mkmelin
: review+
wsmwk
: approval-comm-beta+
wsmwk
: approval-comm-esr68+
Details | Diff | Splinter Review

I'm using the history arrows (back/forward) a lot and just came across this error. We papered over bad URL's here
https://hg.mozilla.org/comm-central/rev/4b9f7d78c4c9
so why not do it again.

Hard to test since we don't know what causes the issue. I haven't tested this, neither have I checked linting (since I don't have a working setup any more). Can you please check this for me. Not an ideal patch, but it will silence the issue and not inhibit the menu from coming up at all (which was the annoying bit before I fixed bug 1600500).

Assignee: nobody → jorgk-bmo
Status: NEW → ASSIGNED
Attachment #9139963 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9139963 [details] [diff] [review]
1629301-skip-bad-history.patch

Review of attachment 9139963 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9139963 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → Thunderbird 77.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/cc0eebd9ddbd
Skip bad history entries so they don't cause errors. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Thanks!

Comment on attachment 9139963 [details] [diff] [review]
1629301-skip-bad-history.patch

Not risky, just working around a "bad" history entry that would otherwise cause a malfunction. Could be useful in TB 68 as well.
Attachment #9139963 - Flags: approval-comm-esr68?
Attachment #9139963 - Flags: approval-comm-beta?
Comment on attachment 9139963 [details] [diff] [review]
1629301-skip-bad-history.patch

[Triage Comment]
Attachment #9139963 - Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 9139963 [details] [diff] [review]
1629301-skip-bad-history.patch

Good in beta, so approved for ESR
Attachment #9139963 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.