Closed Bug 1629425 Opened 3 months ago Closed 2 months ago

DocumentLoadListener.cpp: redundant return statement at the end of a function with a void return type

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: Sylvestre, Assigned: shashvatshah9, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/netwerk/ipc/DocumentLoadListener.cpp#585

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Also, please only work on two max of such bugs.

I want to fix this bug. Please let me know how to get started as it will be my first bug fixing.

You have all the information in the first comment of this bug ;)

Assignee: nobody → shashvatshah9
Status: NEW → ASSIGNED

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:shashvatshah9, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(shashvatshah9)

I landed it

Flags: needinfo?(shashvatshah9)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fae67f16825b
Removed redundant return statement r=necko-reviewers,valentin
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.