1629459 - Addons will not remove

Status: VERIFIED FIXED

(Thunderbird :: Add-Ons: General, defect, P1)

Description

[Greg ( Hank1 )]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

install Addons in Thunderbird 77

Actual results:

i tried to remove them
, i can disable them

but i cannot remove them

Expected results:

i should be able to remove the Addons

Comment 1

[Firefox Bug Husbandry Bot]

Resetting severity to default of --.

Comment 2

[Rob Lemley [:rjl]]

I can confirm this is happening on 78.
Error from dev console:
TypeError: can't access property "promptRemoveExtension", windowRoot.ownerGlobal.BrowserAddonUI is undefinedaboutaddons.js:2894:17

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=79b79390da3539fd9d5576f7eaf948914bafe823&tochange=7ebcf56c0e59161b0e8dade8311e95d23b38980e
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=acc1632e35c7afc826d16bea8e1dd812b4f5117c&tochange=33d2485721c6ffd20a952d698754041a14be11b3

Suspect:
526c65b7b51694b6657d6d284de4af705acbfe48 William Durand — Bug 1489430 - Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer,fluent-reviewers,Gijs

Comment 5

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 6

[Greg ( Hank1 )]

this problem still occurs in 78.

Comment 7

[Mark Banner (:standard8)]

Requesting tracking as this is needs fixing for 78.

Comment 8

[Ping Chen [:rnons] (away)]

Attachment: 1629459.patch

Move promptRemoveExtension function into BrowserAddonUI object.

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9154862 [details] [diff] [review]
1629459.patch

Review of attachment 9154862 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks like the correct follow-up for https://hg.mozilla.org/mozilla-central/rev/526c65b7b516

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9154862 [details] [diff] [review]
1629459.patch

Review of attachment 9154862 [details] [diff] [review]:
-----------------------------------------------------------------

It would be good to mention the ported changeset in the commit comment. 
In the summary please mention the bug we're porting (and why the change was made, if necessary). 

So something like 
Bug 1629459 - Port bug 1489430 to Thunderbird - promptRemoveExtension is now a member of BrowserAddonUI. r=mkmelin

Comment 11

[Ping Chen [:rnons] (away)]

Attachment: 1629459.patch

Updated commit message.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/82b576b3538b
Port bug 1489430 to Thunderbird - promptRemoveExtension is now a member of BrowserAddonUI. r=mkmelin

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9154866 [details] [diff] [review]
1629459.patch

Approved comm-beta (requested by Rob)

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/35dde05748d6

Comment 15

[Rob Lemley [:rjl]]

Verified on 78.0b1