1629583 - [wpt-sync] Sync PR 22899 - Revert "[css-grid] Exclude implicit grid tracks from the resolved value"

Status: RESOLVED INVALID

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 22899 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22899
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

Revert "[css-grid] Exclude implicit grid tracks from the resolved value"

This reverts commit be7909b47a8b489e33b6d7f415d123d4b63663c5.

Reason for revert: This appears to be breaking site authoring tools
which were relying on the previous behaviour.

Bug: 1069866

Original change's description:

[css-grid] Exclude implicit grid tracks from the resolved value

https://github.com/w3c/csswg-drafts/issues/4475 resolved to try to stop
including implicit tracks in the resolved value of grid-template-columns
and grid-template-rows.

This implies that the resolved values will have less information now,
which affects lots of tests. I have edited them depending on the case:

• When the size of the track was irrelevant (e.g. just checking whether
  some value was syntactically valid), I have just updated the expected
  value.
• When the size of the track was relevant, but it wasn't important for
  the tracks to be implicit, I have made them explicit in order to get
  the same value.
• When the test was about the sizes of implicit tracks, I have added
  new checks for the size and position of the grid items.

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EKvyx2lZJXI

Spec: https://drafts.csswg.org/css-grid/#resolved-track-list

Bug: 1024927

Change-Id: I4677c184be263eaab08d4aee95bb868306d58228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897931
Commit-Queue: Oriol Brufau \<[e-mail]>
Reviewed-by: Manuel Rego \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#728894}

TBR=[e-mail],[e-mail],[e-mail]

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1024927
Change-Id: I8ef626b6ed84a9ee581d542072bda63685a46c42

Reviewed-on: https://chromium-review.googlesource.com/2147814
WPT-Export-Revision: 4665b3d22d339c176660e5a5842e243e13c7c256