Open Bug 1629895 Opened 4 years ago Updated 2 years ago

[false negative] Password generation is not offered for the Register password fields on DigiFinex

Categories

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Desktop
All
defect

Tracking

()

Tracking Status
firefox75 --- disabled
firefox76 --- affected
firefox77 --- affected

People

(Reporter: tbabos, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [passwords:generation])

Affected Versions:
Nightly 77.0a1 (2020-04-14) (64-bit)
Beta 76.0b4

Affected Platforms:
Windows 7/10 x64
MacOS 10.14
Ubuntu 18.04

Steps to reproduce:

  1. Go to DigiFinex.com and reach the Register form
  2. Click on the Password and Repeat Password fields

Expected Result:
The autocomplete dropdown should display the Password Generation option

Actual Result:
Password Generation was not offered for the Password and Repeat Password fields

Regression-Range:
Not a regression of this implementation, it also doesn't work in Beta 75

Notes:
Password field:
<input class="pwd-code" placeholder="Password (8-20 Characters)" autocomplete="off" type="password" value="">
<input class="dbpwd-code" placeholder="Repeat password" autocomplete="off" type="password" value="">

Whiteboard: [passwords:generation]

According to its Tranco + Alexa ranking, this site is not among the most popular (which we are currently defining to be the top 500).

Priority: -- → P2

The inputs on this one have autocomplete="off". Does that hurt us?

Flags: needinfo?(bdanforth)

(In reply to Erik Rose [:erik][:erikrose] from comment #2)

The inputs on this one have autocomplete="off". Does that hurt us?

What do you mean? Based on the markup, we run the new password model in this case.

Flags: needinfo?(bdanforth)

Thanks; that's all I needed to know! I just didn't know if, somewhere deep in the app logic, something cared about a value of "off".

No, not for password manager, only for form history/datalist. We and other browsers stopped honoring "off" for the password manager many years ago.

Severity: -- → S3

When testing the model update in bug 1638187 I found that the "password" field was not being recognized (score: 0.3451984868482393) while "repeat password" was (score: 0.8146404853295838).

It's worth noting that this is a live page, though, and these results have been somewhat flaky.

Can also confirm what Severin said on the latest RC 77.0 (20200528194502).
Password Generation is not toggled for the "Password" field but will be toggled for "Repeat Password" .

This was added to the model samples.

Moving to P3 as this is not happening in the next release cycle.

Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.