Closed Bug 1630037 Opened 4 months ago Closed 4 months ago

Unexpected shutdown of the browser hangs Raptor

Categories

(Testing :: Raptor, defect, P1)

Version 3
defect

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [perftest:triage])

Attachments

(1 file)

When I start any kind of Raptor job and then force kill the application via Cmd+Q Raptor hangs. As it looks like we are not correctly checking the process' exit code on a regular basis while the tests are running.

This could cause various hangs without proper reporting. Maybe even related to bug 1627867 when geckoview_example gets killed by the system.

Where in the execution do you run Cmd+Q? Is it equivalent to Ctrl+C? I'm asking because I haven't hit this issue before and I use Ctrl+C a lot.

Just close the browser. Feel free to also use "Firefox | Quit Firefox".

Summary: Force closing Raptor with Cmd+Q hangs Raptor → Force closing Firefox with Cmd+Q hangs Raptor

Oh ok! Thanks for clarifying.

Note that if the application quits without a generated minidump it might show up on Treeherder as Connection to Raptor webextension failed!, or even task aborted. I didn't wait long enough to check which timeout we actually hit.

Here is where we should close the browser after the timeout is finished:

https://searchfox.org/mozilla-central/search?q=wait_for_test_finish&case=true&path=

As just verified also with the upcoming patch for bug 1630952 - when Firefox closes itself for a content crash - Raptor hangs around for about 25 minutes.

Checking the process regularly will also have an effect for CI costs.

Summary: Force closing Firefox with Cmd+Q hangs Raptor → Unexpected shutdown of the browser hangs Raptor
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P2 → P1
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/062f5214f393
[raptor] Immediately bail out for an unexpected shutdown of the browser. r=perftest-reviewers,sparky
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.