1630153 - Perma test_extension_incognito_spanning_grandfathered - [test_extension_incognito_spanning_grandfathered : 31] Got parent telemetry events in the snapshot - "undefined" == true when Gecko version number increases to 78 on on 2020-05-04

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[Alexandru Michis [:malexandru]]

Central as Version Increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=4b5ccefba5f619f1940a9bb21aae5e5b7072fb9c&searchStr=%28x&selectedJob=297544787

Failure logs:

• test_extension_incognito_spanning_grandfathered.js:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297544787&repo=try&lineNumber=3186
• test_ext_storage_idb_data_migration.js:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297544787&repo=try&lineNumber=3342
• test_ext_storage_idb_data_migration.js:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297544787&repo=try&lineNumber=3342
• test_AbuseReporter.js:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297544787&repo=try&lineNumber=3484
• test_addon_manager_telemetry_events.js:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297544787&repo=try&lineNumber=3609

[task 2020-04-14T14:58:43.667Z] 14:58:43     INFO -  TEST-START | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_upgrade.js
[task 2020-04-14T14:58:54.247Z] 14:58:54     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_upgrade.js | took 10578ms
[task 2020-04-14T14:58:54.250Z] 14:58:54     INFO -  Retrying tests that failed when run in parallel.
[task 2020-04-14T14:58:54.254Z] 14:58:54     INFO -  TEST-START | dom/push/test/xpcshell/test_unregister_invalid_json.js
[task 2020-04-14T14:58:57.133Z] 14:58:57     INFO -  TEST-PASS | dom/push/test/xpcshell/test_unregister_invalid_json.js | took 2879ms
[task 2020-04-14T14:58:57.140Z] 14:58:57     INFO -  TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_extensionSettingsStore.js
[task 2020-04-14T14:59:09.376Z] 14:59:09     INFO -  TEST-PASS | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_extensionSettingsStore.js | took 12236ms
[task 2020-04-14T14:59:09.383Z] 14:59:09     INFO -  TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_incognito.js
[task 2020-04-14T14:59:20.523Z] 14:59:20  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_incognito.js | xpcshell return code: 0
[task 2020-04-14T14:59:20.524Z] 14:59:20     INFO -  TEST-INFO took 11137ms
[task 2020-04-14T14:59:20.525Z] 14:59:20     INFO -  >>>>>>>
[task 2020-04-14T14:59:20.525Z] 14:59:20     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-04-14T14:59:20.526Z] 14:59:20     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2020-04-14T14:59:20.526Z] 14:59:20     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-04-14T14:59:20.527Z] 14:59:20     INFO -  running event loop
[task 2020-04-14T14:59:20.527Z] 14:59:20     INFO -  xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_incognito.js | Starting check_remote
[task 2020-04-14T14:59:20.527Z] 14:59:20     INFO -  (xpcshell/head.js) | test check_remote pending (2)
[task 2020-04-14T14:59:20.528Z] 14:59:20     INFO -  TEST-PASS | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_incognito.js | check_remote - [check_remote : 1] useRemoteWebExtensions matches - true == true

Luca, could you please take a look?

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Alexandru,
Bug 1630596 has been landed and so this should now be fixed, do you confirm that this perma fail does not happen anymore in a new 78 version increase simulation?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Code sheriffs will run the next version increase simulation on Monday and resolve this bug if the issue is gone.

Comment 3

[Alexandru Michis [:malexandru]]

Luca, there are still failures on test_ext_storage_idb_data_migration.js:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=299542659&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=56005e89ee3a807791a0457f6fab7c4d47150779&searchStr=%28x

Could you please take a look?

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Alexandru Michis [:malexandru] from comment #3)

Luca, there are still failures on test_ext_storage_idb_data_migration.js:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=299542659&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=56005e89ee3a807791a0457f6fab7c4d47150779&searchStr=%28x

Could you please take a look?

I'm on it, I missed to notice that extensions.data.migrateResult was also set to expire on 78 and it wasn't yet part of the probes already extended in Bug 1630596.
I'm going to attach an additional data renewal review request and a new patch to Bug 1630596.

Comment 5

[Alexandru Michis [:malexandru]]

Luca,
I'm also seeing these awsy failures appearing again: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=56005e89ee3a807791a0457f6fab7c4d47150779&searchStr=awsy&selectedJob=299569862

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The OS X sy-d are expected permafails.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Based on Bug 1630596 Comment 12 this should be fixed now.