163031 - Marquee tag does not support css correctly

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P4)

Description

[José Jeria]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1b) Gecko/20020813
BuildID:    20020813

The tag Marquee does not suppport some css. For example 
font-family:Verdana;
works, but using other css properties dont work at all.

See testcase.

Reproducible: Always
Steps to Reproduce:
1. Run testcase
2. Css is not applied in a correct way

Comment 1

[José Jeria]

Attachment: Testcase

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: partial fix

This fixes a good bit of it, although 'width' is still broken.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Doron, could you review?

Comment 4

[Doron Rosenberg (IBM)]

Comment on attachment 95563 [details] [diff] [review]
partial fix

r=doron

Comment 5

[Doron Rosenberg (IBM)]

might consider this for 1.0.1

Comment 6

[Mats Palmgren (inactive)]

*** Bug 163401 has been marked as a duplicate of this bug. ***

Comment 7

[kinmoz]

Comment on attachment 95563 [details] [diff] [review]
partial fix

IE4 seems to treat marquee as an inline, but dbaron tells me that the XBL
implementation of marquee in mozilla uses blocks etc.

I'll sr=[e-mail] this patch so that we can style the current
implementation, but if we really want to be compatible with MS we'll need to
make our implementation an inline.

As a testcase, I simply modified attachment 95560 [details] to look something like:

  Before <marquee> ... </marquee> After

Comment 8

[Doron Rosenberg (IBM)]

according to msdn
(http://msdn.microsoft.com/workshop/author/dhtml/reference/objects/marquee.asp):

This element is a block element.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm going to mark this fixed, since it's as fixed as I'm going to make it.  (Fix
checked in, 2002-08-19 11:43 PDT.)

However, I filed two new bugs:
 * bug 163504, to investigate whether it should really be inline-block
 * bug 163505, which would cover fixing the remaining problems with the 'width'
property

Comment 10

[José Jeria]

Will this make it to 1.0.1?

Comment 11

[Madhur Bhatia]

verifying based on comments.
The broken width is being looked into in bug 163505