1630371 - Disable DirectComposition when we have a scaled resolution and no hardware stretching.

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1630371 - Disable DirectComposition when we have a scaled resolution and no hardware stretching.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fce1cf0a2abb
Disable DirectComposition when we have a scaled resolution and no hardware stretching. r=aosmond

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1630371 - Disable DirectComposition when we have a scaled resolution and no hardware stretching.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9141079 [details]
Bug 1630371 - Disable DirectComposition when we have a scaled resolution and no hardware stretching.

Beta/Release Uplift Approval Request

• User impact if declined: This loosens the condition that we use for disabling DirectComposition. Without this users are missing out on the performance and battery improvements that DirectComposition gives. This is especially important because 76 enables WebRender on some Intel laptops.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Try using Firefox on a machine where DirectComposition was disabled because of lack of HardwareStretching. It should now have DirectComposition.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just turning on DirectComposition in more situations. The result of the HardwareStretching test is not always what we expected so we ended up disabling DirectComposition on a somewhat random set of users in 75. That served as rough mechanism for gradual rollout. This patch serves to complete that rollout.
• String changes made/needed:

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fce1cf0a2abb

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9141079 [details]
Bug 1630371 - Disable DirectComposition when we have a scaled resolution and no hardware stretching.

Needed for Intel WebRender rollout. Approved for 76.0b6.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/834249a71490

Comment 8

[Sotaro Ikeda [:sotaro]]

deleted

Comment 9

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Beta build 76.0b7 and our latest Nightly build 77.0a1 (2020-04-22) on Windows 10.