1630497 - Remove test-specific pref-setting of "dom.audioworklet.enabled" and "dom.worklet.enabled"

Status: RESOLVED FIXED

(Core :: Web Audio, task, P2)

Description

[Karl Tomlinson (:karlt)]

These are no longer necessary since changes for bug 1616725.

Comment 1

[Arnaud Bienner]

Do we also want to remove Pref="dom.audioworklet.enabled" from webidl files? (as part of this bug or a new, separate one)

Comment 2

[Paul Adenot (:padenot)]

Probably, yes. I don't see why we would disable AudioWorklet, it's been shipping for some time now.

Comment 3

[Karl Tomlinson (:karlt)]

The only reason we'd disable now would be if some active security exploit needed to be disabled quickly.

I don't see any guidance on https://wiki.mozilla.org/ExposureGuidelines re when to remove preferences. Looking through the history of dom/webidl, I had to go back seven months to find precedent for removing these from bug 1578241. Removing the prefs from the webidl files now would be consistent with that.

One reason to do the webidl files and the pref itself separately from the tests would be that I can review test file changes, but I assume we need a DOM peer to review webidl file changes. I'm somewhat confused about the latter because the moz.build file delegates back to the "Web Audio" module.

Comment 4

[Gregory Pappas [:gregp]]

Attachment: Bug 1630497 - Remove dom.audioworklet.enabled and dom.worklet.enabled prefs r?padenot!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16c42273dc28
Remove dom.audioworklet.enabled and dom.worklet.enabled prefs r=padenot,webidl,saschanaz

Comment 6

[Cristian Tuns]

Backed out for causing mochitest failures in dom/worklet/tests/*

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/worklet/tests/test_audioWorklet_insecureContext.html | uncaught exception - ReferenceError: configureTest is not defined at window.onload@http://mochi.test:8888/tests/dom/worklet/tests/common.js:6:5

Comment 7

[Gregory Pappas [:gregp]]

Thanks, working on it. I see what the problem is

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef60c7cdcb76
Remove dom.audioworklet.enabled and dom.worklet.enabled prefs r=padenot,webidl,saschanaz

Comment 9

[Cristian Tuns]

Backed out for causing multiple mochitest failures in dom/worklet/tests/*

• Backout link
• Push with failures
• [Failure Log](TEST-UNEXPECTED-FAIL | dom/worklet/tests/test_audioWorklet.html | uncaught exception - TypeError: can't access property "then", configureTest() is undefined at window.onload@https://example.com/tests/dom/worklet/tests/common.js:13:5)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d5aa2b4379b
Remove dom.audioworklet.enabled and dom.worklet.enabled prefs r=padenot,webidl,saschanaz

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5d5aa2b4379b