Closed Bug 1630540 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22994 - DedicatedWorker: Refine WPTs to test parse error handling

Categories

(Core :: DOM: Workers, task, P4)

Product:
Core
Component:
DOM: Workers
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22994 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22994
Details from upstream follow.

Eriko Kurimoto <elkurin@chromium.org> wrote:

DedicatedWorker: Refine WPTs to test parse error handling

This CL modifies web-platform-test for parse error handling in classic
and module dedicated workers.
This CL does followings:

  1. Divide workers/modules/dedicated-worker-parse-error-failure.html into
    the tests for classic workers and for module workers.
  2. For module workers, check if module script is supported before
    testing parse error handling.
  3. Check the content of the dispatched event.

This change is based on WPTs for shared workers parse error handling.

Bug: 1071345
Change-Id: I738c89d5241a94df17092a3b106b5b795a26a7de
Reviewed-on: https://chromium-review.googlesource.com/2152330
WPT-Export-Revision: 05fefc76009d4c88fd618b8d16e166b29b446ba6

Component: web-platform-tests → DOM: Workers
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 66 tests

Status Summary

Firefox

OK : 1
PASS : 64
FAIL : 2
ERROR : 1
NOTRUN: 2

Chrome

OK : 2
PASS : 2
FAIL : 2

Safari

OK : 1
FAIL : 2
ERROR : 1
NOTRUN: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/workers/dedicated-worker-parse-error-failure.html
Static import on classic worker should dispatch an event named error.: FAIL (Chrome: FAIL, Safari: FAIL)
Classic worker construction for script with syntax error should dispatch an event named error.: FAIL (Chrome: FAIL, Safari: FAIL)
/workers/modules/dedicated-worker-parse-error-failure.html: ERROR (Chrome: OK, Safari: ERROR)
Module worker construction for script with syntax error should dispatch an event named error.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Static import on module worker for script with syntax error should dispatch an event named error.: NOTRUN (Chrome: PASS, Safari: NOTRUN)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6ebb1b3f1e4
[wpt PR 22994] - DedicatedWorker: Refine WPTs to test parse error handling, a=testonly
https://hg.mozilla.org/integration/autoland/rev/6e66a8368620
[wpt PR 22994] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/175fd05289e1
[wpt PR 22994] - DedicatedWorker: Refine WPTs to test parse error handling, a=testonly
https://hg.mozilla.org/integration/autoland/rev/99abccb00c35
[wpt PR 22994] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/175fd05289e1
https://hg.mozilla.org/mozilla-central/rev/99abccb00c35

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.