Closed Bug 1630541 Opened 5 years ago Closed 5 years ago

62.11% build times (android-4-0-armv7-api16) regression on push 5fdba2915ccf63e82198539563a0056275c3db5b (Wed April 15 2020)

Categories

(Core :: Graphics: WebGPU, defect)

defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- unaffected
firefox77 --- wontfix

People

(Reporter: marauder, Assigned: kvark)

References

(Regression)

Details

(Keywords: perf-alert, regression)

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=5fdba2915ccf63e82198539563a0056275c3db5b

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

62% build times android-4-0-armv7-api16 debug taskcluster-c5d.4xlarge 840.97 -> 1,363.27

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=25627

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Looking in treeherder, the changeset 1dc7cd341a2a looks like it introduced the regression:

  • build times debug taskcluster-c5.4xlarge: 1326.81

The changeset before (400c3278b009) has:

  • build times debug taskcluster-c5.4xlarge: 758.99

The changeset after (5fdba2915ccf - where perfherder created the alert) has:

  • build times debug taskcluster-c5d.4xlarge: 1348.88

Graph view:
https://treeherder.mozilla.org/perf.html#/graphs?highlightAlerts=1&series=autoland,1962366,1,2&series=autoland,1618231,1,2&timerange=1209600&zoom=1586900989147,1586910647261,489.7762844612945,1603.2935855199635

Hey Sean, what do you think about the regression ?
Thanks!

Blocks: 1628613
Component: Performance → DOM: Core & HTML
Flags: needinfo?(sefeng)
Product: Testing → Core
Regressed by: 1580603
Version: Version 3 → unspecified

hmm, the changeset shows Bug 1629738 and I don't think I am involved in this change set?

Flags: needinfo?(sefeng) → needinfo?(marian.raiciof)

Dimitri, would you mind taking a look at this one?

Flags: needinfo?(dmalyshau)
Flags: needinfo?(marian.raiciof)
Regressed by: 1629738
No longer regressed by: 1580603
Has Regression Range: --- → yes
Component: DOM: Core & HTML → Graphics: WebGPU

This is pretty strange to see. There wasn't a lot of new code to justify this.

Assignee: nobody → dmalyshau
Flags: needinfo?(dmalyshau)

Marian,

It doesn't make much sense that this patch would increase the build time on Android by 62% by itself.
Looking at the graph, it appears to be going back and forth within this range of 600 to 1800, and it didn't change noticeably after the fix for bug 1629738 was merged.

Could it be a false alarm?

Flags: needinfo?(marian.raiciof)

Hey Dzmitry, yes i agree with that.
I'll mark this as invalid.
Thanks!

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(marian.raiciof)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.