1630636 - ./mach try fuzzy failed with python error due to string getting exploded into chars

Status: RESOLVED DUPLICATE of bug 1630605

(Developer Infrastructure :: Try, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Pulled latest m-c today and tried a ./mach try fuzzy. Picked the job I wanted but it failed on submit:

$ ./mach try fuzzy
Task configuration changed, generating target task set
estimates: Runs 1 tasks (1 selected, 0 dependencies)
estimates: Total task duration 0:27:53
estimates: In the 84% percentile
estimates: Should take about 0:36:34 (Finished around 2020-04-16 11:31)
fatal: /: '/' is outside repository
Error running mach:

    ['try', 'fuzzy']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

CalledProcessError: Command '(u'/usr/local/bin/git', u'add', '/', 'U', 's', 'e', 'r', 's', '/', 'k', 'a', 't', 's', '/', 'z', 's', 'p', 'a', 'c', 'e', '/', 'g', 'e', 'c', 'k', 'o', '-', 'm', 'a', 'c', '/', 't', 'r', 'y', '_', 't', 'a', 's', 'k', '_', 'c', 'o', 'n', 'f', 'i', 'g', '.', 'j', 's', 'o', 'n')' returned non-zero exit status 128

  File "/Users/kats/zspace/gecko-mac/tools/tryselect/mach_commands.py", line 307, in try_fuzzy
    return self.run(**kwargs)
  File "/Users/kats/zspace/gecko-mac/tools/tryselect/mach_commands.py", line 177, in run
    return mod.run(**kwargs)
  File "/Users/kats/zspace/gecko-mac/tools/tryselect/selectors/fuzzy.py", line 388, in run
    closed_tree=closed_tree)
  File "/Users/kats/zspace/gecko-mac/tools/tryselect/push.py", line 178, in push_to_try
    vcs.add_remove_files(*changed_files)
  File "/Users/kats/zspace/gecko-mac/python/mozversioncontrol/mozversioncontrol/__init__.py", line 509, in add_remove_files
    self._run('add', *paths)
  File "/Users/kats/zspace/gecko-mac/python/mozversioncontrol/mozversioncontrol/__init__.py", line 115, in _run
    universal_newlines=True)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 223, in check_output
    raise CalledProcessError(retcode, cmd, output=output)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Guessing this is a regression from bug 1630047 which touched relevant code recently.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Backing out bug 1630047 fixes the problem for me, so confirmed that it's a regression from that bug.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Doh, :jgraham already filed this.