Closed Bug 1630700 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23023 - Replace assert_precondition with assert_equals in native-io/

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox77 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23023 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23023
Details from upstream follow.

Stephen McGruer <smcgruer@chromium.org> wrote:

Replace assert_precondition with assert_equals in native-io/

assert_precondition is deprecated (see
https://github.com/web-platform-tests/rfcs/blob/master/rfcs/assert_precondition_rename.md).
The usage in these tests was to check equality rather than whether a
feature was supported, so replace with assert_equals.

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 73 tests

Status Summary

Firefox

OK : 9
PASS : 64
FAIL : 43

Chrome

OK : 9
PASS : 43

Safari

OK : 7
FAIL : 33
ERROR: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/native-io/close_async.tentative.https.any.html
NativeIOFile.read fails after NativeIOFile.close settles: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.close is idempotent: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.write fails after NativeIOFile.close settles: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.write fails immediately after calling NativeIOFile.close: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.close is idempotent when called immediately: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.read fails immediately after calling NativeIOFile.close: FAIL (Chrome: PASS, Safari: FAIL)
/native-io/close_async.tentative.https.any.worker.html
NativeIOFile.read fails after NativeIOFile.close settles: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.close is idempotent: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.write fails after NativeIOFile.close settles: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.write fails immediately after calling NativeIOFile.close: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.close is idempotent when called immediately: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.read fails immediately after calling NativeIOFile.close: FAIL (Chrome: PASS, Safari: FAIL)
/native-io/concurrent_io_async.tentative.https.any.html
write() rejects wrile write() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
read() rejects wrile read() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
read() rejects wrile write() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
write() rejects wrile read() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
/native-io/close_async.tentative.https.any.serviceworker.html
NativeIOFile.read fails after NativeIOFile.close settles: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.close is idempotent: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.write fails after NativeIOFile.close settles: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.write fails immediately after calling NativeIOFile.close: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.close is idempotent when called immediately: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.read fails immediately after calling NativeIOFile.close: FAIL (Chrome: PASS, Safari: FAIL)
/native-io/close_async.tentative.https.any.sharedworker.html
NativeIOFile.read fails after NativeIOFile.close settles: FAIL (Chrome: PASS)
NativeIOFile.close is idempotent: FAIL (Chrome: PASS)
NativeIOFile.write fails after NativeIOFile.close settles: FAIL (Chrome: PASS)
NativeIOFile.write fails immediately after calling NativeIOFile.close: FAIL (Chrome: PASS)
NativeIOFile.close is idempotent when called immediately: FAIL (Chrome: PASS)
NativeIOFile.read fails immediately after calling NativeIOFile.close: FAIL (Chrome: PASS)
/native-io/concurrent_io_async.tentative.https.any.serviceworker.html
write() rejects wrile write() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
read() rejects wrile read() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
read() rejects wrile write() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
write() rejects wrile read() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
/native-io/concurrent_io_async.tentative.https.any.sharedworker.html
write() rejects wrile write() is resolving: FAIL (Chrome: PASS)
read() rejects wrile read() is resolving: FAIL (Chrome: PASS)
read() rejects wrile write() is resolving: FAIL (Chrome: PASS)
write() rejects wrile read() is resolving: FAIL (Chrome: PASS)
/native-io/concurrent_io_async.tentative.https.any.worker.html
write() rejects wrile write() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
read() rejects wrile read() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
read() rejects wrile write() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
write() rejects wrile read() is resolving: FAIL (Chrome: PASS, Safari: FAIL)
/native-io/close_sync.tentative.https.any.worker.html
nativeIO.close is idempotent: FAIL (Chrome: PASS, Safari: FAIL)
nativeIO.read fails after nativeIO.close settles: FAIL (Chrome: PASS, Safari: FAIL)
NativeIOFile.write fails after NativeIOFile.close: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e32697836293
[wpt PR 23023] - Replace assert_precondition with assert_equals in native-io/, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/bcfa61b269a1
[wpt PR 23023] - Replace assert_precondition with assert_equals in native-io/, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bcfa61b269a1

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.