1630877 - Audio worklets should only have a SharedArrayBuffer global property if COOP/COEP permits it

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P1)

Description

[Jeff Walden [:Waldo]]

Bug 1624266 will cause the global SharedArrayBuffer property to only be present if a page is served with COOP/COEP headers that opt into cross-site isolation. This needs to be applied to audio worklets, too -- by changing the value assigned to defineSharedArrayBufferConstructor in AudioWorkletGlobalScope.cpp. (I/we haven't bothered doing it there because audio worklets aren't implemented yet [right?].)

Comment 1

[Paul Adenot (:padenot)]

(In reply to Jeff Walden [:Waldo] from comment #0)

(I/we haven't bothered doing it there because audio worklets aren't implemented yet [right?].)

We have finished implementation and we're shipping in 76. Do you want to do it? I can certainly do it if you point me to an example, if that helps.

Comment 2

[Anne (:annevk)]

Please apologize the somewhat aggressive needinfo-ing, but the hope was to ship this in 78 and that branches a week from now if I'm reading https://wiki.mozilla.org/Release_Management/Calendar correctly. What are the chances of making that?

(On the other hand, given that it's not a security issue (postMessage() throws after all) and audio worklets are very new, I somewhat doubt we would hit any of the potential compatibility issues we're hiding globalThis.SharedArrayBuffer for. So it might be okay to ship and address this later.)

Comment 3

[Tom Tung [:tt, :ttung]]

I did that in D71536 so I guess we can close this bug when Bug 1624266 is fixed or move the patch to here.