Closed Bug 1630896 Opened 4 months ago Closed 3 months ago

Give SeaMonkey langpacks an internalName

Categories

(SeaMonkey :: Build Config, task)

Tracking

(seamonkey2.53 fixed)

RESOLVED FIXED
Tracking Status
seamonkey2.53 --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file, 2 obsolete files)

At the moment langpacks that are built from SeaMonkey do not have an internalName set, we should probably set one.

Attached patch Add internalName to SM langpacks (obsolete) — Splinter Review

As we now make use of toolkit's generic locale install.rdf that is what needs patching.

Attachment #9141212 - Flags: review?(frgrahl)
Attachment #9141212 - Flags: approval-comm-release?
Attachment #9141212 - Flags: approval-comm-esr60?
Comment on attachment 9141212 [details] [diff] [review]
Add internalName to SM langpacks

Not needed for 2.57
Attachment #9141212 - Flags: approval-comm-esr60?

More agnostic version

Attachment #9141212 - Attachment is obsolete: true
Attachment #9141212 - Flags: review?(frgrahl)
Attachment #9141212 - Flags: approval-comm-release?
Attachment #9141222 - Flags: review?(frgrahl)
Attachment #9141222 - Flags: approval-comm-esr60?

Sorry for the noise, with tab rather than spaces

Attachment #9141222 - Attachment is obsolete: true
Attachment #9141222 - Flags: review?(frgrahl)
Attachment #9141222 - Flags: approval-comm-esr60?
Attachment #9141223 - Flags: review?(frgrahl)
Attachment #9141223 - Flags: approval-comm-release?
Blocks: 1618866
Comment on attachment 9141223 [details] [diff] [review]
Add internalName to SM langpacks v1.2

LGTM. Assuming for 2.53.2 Beta language pack refresh.
Attachment #9141223 - Flags: review?(frgrahl)
Attachment #9141223 - Flags: review+
Attachment #9141223 - Flags: approval-comm-release?
Attachment #9141223 - Flags: approval-comm-release+
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.