1630952 - With content crashes the browser doesn't immediately exit

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Run a test like: mach raptor --test raptor-tp6-outlook-firefox --post-startup-delay 0

Then while the page loads, paste about:crashcontent into the urlbar. That crashes the tab, and leaves Firefox hanging around for 25 minutes before Raptor kills the browser:

12:39:12     INFO -  raptor-control-server Info: received webext_status: ended page cycle 16
13:04:58     INFO -  mozcrash Copy/paste: /Users/henrik/bin/macosx64_minidump_stackwalk /var/folders/c2/q_47wqh13n902fj9_zxczclr0000gn/T/tmp3t6PdC/minidumps/44529466-92F3-4345-A9DA-A215361FD97E.dmp /var/folders/c2/q_47wqh13n902fj9_zxczclr0000gn/T/tmpRQR3FI

To instruct eg. Firefox to immediately shutdown the MOZ_CRASHREPORTER_SHUTDOWN environment variable has to be passed to the browser.

Note that due to bug 1630037 Raptor still hangs.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With that env variable in place we save 25 minutes per task if Firefox crashes.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1630952 - [raptor] Force browser to shutdown itself for content crashes.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

this is a really great find. are there any risks of adding this ENV VAR?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

also will this work for Android?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #3)

this is a really great find. are there any risks of adding this ENV VAR?

No, it's basically in use by nearly all the other harnesses meanwhile. And with the tab crashed we can't / don't want to continue anyway.

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #4)

also will this work for Android?

Yes, my patch also includes it for Android.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08be5b95d8bb
[raptor] Force browser to shutdown itself for content crashes. r=perftest-reviewers,sparky

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/08be5b95d8bb