Closed Bug 1630986 Opened 4 years ago Closed 4 years ago

Notify when MediaTrackGraph has started

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: achronop, Assigned: achronop)

References

Details

Attachments

(1 file)

The existing MTG::NotifyWhenGraphStarted logic has been modified to work for any track and not only AudioNodeTrack. Also, a unit test has been created to verify the behavior.

This is needed for setSinkId, and to solve and android intermittent.

The existing MTG::NotifyWhenGraphStarted() has been modified to work with a MediaTrack (the parent) instead of AudioNodeTrack. Also, a unit test has been added to verify the behavior.

Assignee: nobody → achronop
Status: NEW → ASSIGNED

The problem, in the try run from above, is that the processing of the audio begins from the fallback thread. However, with this patch, the state of AudioContext changes to "running" later on, in the audio thread. Since the audio is being processed already from the fallback thread it was a mistake to resolve the promise of the MTG::NotifyWhenGraphStarted() in the audio thread. I will change the patch to restore that logic and will create a new method that the returned promise will resolve in the audio thread.

Attachment #9141281 - Attachment description: Bug 1630986 - Modify notification method to work with any MediaTrack. r?padenot → Bug 1630986 - Notify asynchonusly when the audio device has started. r?padenot
Attachment #9141281 - Attachment description: Bug 1630986 - Notify asynchonusly when the audio device has started. r?padenot → Bug 1630986 - Notify asynchronously when the audio device has started. r?padenot
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecfc8ebb5848
Notify asynchronously when the audio device has started. r=padenot
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: